Move test-only code to GN target rtc_base_test_utils.

Move test-only code to GN target rtc_base_test_utils.

VirtualSocketServer and Sha1Digest (from rtc_base)
md5.h and md5.cc (from rtc_base_approved, Md5Digest was moved earlier)

BUG=None

Review-Url: https://codereview.webrtc.org/2875933002
Cr-Commit-Position: refs/heads/master@{#18119}
Committed: https://chromium.googlesource.com/external/webrtc/+/cdcc6b3fe6c7431a4579341da4f27f851d24b59d

[nisse-webrtc, 2017-05-11 12:30:46]

Description was changed from

==========
Move VirtualSocketServer to test target.

BUG=None
==========

to

==========
Move test-only code to GN target rtc_base_test_utils.

VirtualSocketServer and Sha1Digest (from rtc_base)
md5.h and md5.cc (from rtc_base_approved, Md5Digest was moved earlier)

BUG=None
==========

[nisse-webrtc, 2017-05-11 12:30:46]

nisse@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[nisse-webrtc, 2017-05-11 12:40:50]

PTAL.

[kwiberg-webrtc, 2017-05-11 12:55:59]

Hmmm... How is it a good idea for us to have our own md5 and sha1
implementations, instead of using a library? Especially for test code, where
binary size isn't an issue?

[kjellander_webrtc, 2017-05-11 13:02:27]

On 2017/05/11 12:55:59, kwiberg-webrtc wrote:
> Hmmm... How is it a good idea for us to have our own md5 and sha1
> implementations, instead of using a library? Especially for test code, where
> binary size isn't an issue?

These MD5 and SHA1 implementations are not code we've written, they're copied
from Public Domain open sourced code AFAIK. We always want to compile from
source, don't we, so there's no need for a library which might be hard to get on
all the platforms, right?

lgtm assuming you also run the Chromium trybots and the internal one.

[nisse-webrtc, 2017-05-11 13:33:15]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 13:33:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-11 14:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:29:26]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-05-12 07:59:21]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-05-12 07:59:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-12 08:02:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494575961559650,
"parent_rev": "054be4c9d94757803df85239bae8a6e8531115f7", "commit_rev":
"cdcc6b3fe6c7431a4579341da4f27f851d24b59d"}

[commit-bot: I haz the power, 2017-05-12 08:02:30]

Description was changed from

==========
Move test-only code to GN target rtc_base_test_utils.

VirtualSocketServer and Sha1Digest (from rtc_base)
md5.h and md5.cc (from rtc_base_approved, Md5Digest was moved earlier)

BUG=None
==========

to

==========
Move test-only code to GN target rtc_base_test_utils.

VirtualSocketServer and Sha1Digest (from rtc_base)
md5.h and md5.cc (from rtc_base_approved, Md5Digest was moved earlier)

BUG=None

Review-Url: https://codereview.webrtc.org/2875933002
Cr-Commit-Position: refs/heads/master@{#18119}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cdcc6b3fe6c7431a4579341da...
==========

[commit-bot: I haz the power, 2017-05-12 08:02:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/cdcc6b3fe6c7431a4579341da...