Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2875823003: Replace RingBuffer by std::deque in RtcEventLog. (Closed)

Created:
3 years, 7 months ago by terelius
Modified:
3 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace RingBuffer by std::deque in RtcEventLog. BUG=webrtc:7732 Review-Url: https://codereview.webrtc.org/2875823003 Cr-Commit-Position: refs/heads/master@{#18447} Committed: https://chromium.googlesource.com/external/webrtc/+/1c187dcd80c30e7c677dcfb26ee4d9d4d35c67b2

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Remove default-constructed members from constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc View 1 2 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
terelius
3 years, 6 months ago (2017-06-01 14:42:05 UTC) #6
tommi
lgtm https://codereview.webrtc.org/2875823003/diff/20001/webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc File webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc (right): https://codereview.webrtc.org/2875823003/diff/20001/webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc#newcode41 webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.cc:41: history_(), Nit: might as well just remove from ...
3 years, 6 months ago (2017-06-01 21:29:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2875823003/40001
3 years, 6 months ago (2017-06-05 15:53:39 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 15:55:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1c187dcd80c30e7c677dcfb26...

Powered by Google App Engine
This is Rietveld 408576698