Disable the residual echo detector in audio mixer.

Disable the residual echo detector in audio mixer.

The audio mixer has a subcomponent called FrameCombiner, which uses an
AudioProcessing instance as a limiter. The limiter smoothly increases
the volume to avoid causing clipping.

The limiter was created in a default configuration causing the
ResidualEchoDetector submodule of AudioProcessing to be
activated. That submodule operates in the band-split domain (see
AudioProcessingImpl::ApmSubmoduleStates::RenderMultiBandSubModulesActive()).

There is a goal to remove the (expensive and unnecessary)
band-splitting from AudioMixer. This change helps accomplish that. (It
can't be done yet, because the actual limiter sub-component of APM
also operates in the band-split domain).

BUG=webrtc:6185
Review-Url: https://codereview.webrtc.org/2875623002
Cr-Commit-Position: refs/heads/master@{#18090}
Committed: https://chromium.googlesource.com/external/webrtc/+/0f23fa876800f40804bf038c02e7d65f38f01863

[aleloi, 2017-05-10 11:40:51]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 11:40:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2017-05-10 11:41:31]

aleloi@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[aleloi, 2017-05-10 11:41:32]

PTAL!

[commit-bot: I haz the power, 2017-05-10 12:00:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:00:44]

Dry run: This issue passed the CQ dry run.

[ivoc, 2017-05-11 07:22:28]

Good catch, lgtm!

[aleloi, 2017-05-11 07:22:50]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2017-05-11 07:22:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-11 07:25:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494487370836290, "parent_rev":
"77c6e9dfa53bbcc6e191354d0b76111f1d1b32c7", "commit_rev":
"0f23fa876800f40804bf038c02e7d65f38f01863"}

[commit-bot: I haz the power, 2017-05-11 07:25:49]

Description was changed from

==========
Disable the residual echo detector in audio mixer.

The audio mixer has a subcomponent called FrameCombiner, which uses an
AudioProcessing instance as a limiter. The limiter smoothly increases
the volume to avoid causing clipping.

The limiter was created in a default configuration causing the
ResidualEchoDetector submodule of AudioProcessing to be
activated. That submodule operates in the band-split domain (see
AudioProcessingImpl::ApmSubmoduleStates::RenderMultiBandSubModulesActive()).

There is a goal to remove the (expensive and unnecessary)
band-splitting from AudioMixer. This change helps accomplish that. (It
can't be done yet, because the actual limiter sub-component of APM
also operates in the band-split domain).

BUG=webrtc:6185
==========

to

==========
Disable the residual echo detector in audio mixer.

The audio mixer has a subcomponent called FrameCombiner, which uses an
AudioProcessing instance as a limiter. The limiter smoothly increases
the volume to avoid causing clipping.

The limiter was created in a default configuration causing the
ResidualEchoDetector submodule of AudioProcessing to be
activated. That submodule operates in the band-split domain (see
AudioProcessingImpl::ApmSubmoduleStates::RenderMultiBandSubModulesActive()).

There is a goal to remove the (expensive and unnecessary)
band-splitting from AudioMixer. This change helps accomplish that. (It
can't be done yet, because the actual limiter sub-component of APM
also operates in the band-split domain).

BUG=webrtc:6185

Review-Url: https://codereview.webrtc.org/2875623002
Cr-Commit-Position: refs/heads/master@{#18090}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0f23fa876800f40804bf038c0...
==========

[commit-bot: I haz the power, 2017-05-11 07:25:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0f23fa876800f40804bf038c0...