Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2874753003: DCHECK that we don't insert nullptr into event log. (Closed)

Created:
3 years, 7 months ago by terelius
Modified:
3 years, 7 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

DCHECK that we don't insert nullptr into event log. BUG=None Review-Url: https://codereview.webrtc.org/2874753003 Cr-Commit-Position: refs/heads/master@{#18100} Committed: https://chromium.googlesource.com/external/webrtc/+/8a329652de719b5efab5421019ebdc343c57deba

Patch Set 1 #

Patch Set 2 : Added one more check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
terelius
3 years, 7 months ago (2017-05-11 08:49:07 UTC) #2
philipel
lgtm
3 years, 7 months ago (2017-05-11 11:29:50 UTC) #3
philipel
lgtm
3 years, 7 months ago (2017-05-11 11:41:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2874753003/20001
3 years, 7 months ago (2017-05-11 12:01:48 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 13:05:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8a329652de719b5efab542101...

Powered by Google App Engine
This is Rietveld 408576698