Remove gflags dependency for event_log_visualizer and activity_metric

Remove gflags dependency for event_log_visualizer and activity_metric

This is the first step towards getting rid of gflags as a dependency.
It has been causing us extra work for a long time since it's not present
in Chromium as one example.

BUG=webrtc:7644
NOTRY=True

Review-Url: https://codereview.webrtc.org/2874403003
Cr-Commit-Position: refs/heads/master@{#18157}
Committed: https://chromium.googlesource.com/external/webrtc/+/4fa5be451f8a046845bff45bca604badd8ca0fc4

[kjellander_webrtc, 2017-05-12 14:01:58]

kjellander@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, noahric@chromium.org

[kjellander_webrtc, 2017-05-12 14:01:58]

The only drawback with this as I see it is that you don't get any support for
actually printing the flags when --help is provided. I guess we could try to
implement/copy that code from somewhere.
Noah: do you happen to know where from?

[kjellander_webrtc, 2017-05-15 20:09:46]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2017-05-15 20:10:04]

kjellander@webrtc.org changed reviewers:
+ mbonadei@webrtc.org

[kjellander_webrtc, 2017-05-15 20:10:05]

Ping!

Adding Mirko for input as well.

[kwiberg-webrtc, 2017-05-16 04:10:09]

lgtm

https://codereview.webrtc.org/2874403003/diff/40001/webrtc/tools/agc/activity...
File webrtc/tools/agc/activity_metric.cc (right):

https://codereview.webrtc.org/2874403003/diff/40001/webrtc/tools/agc/activity...
webrtc/tools/agc/activity_metric.cc:372: std::string usage =
Wouldn't it make more sense to change this to a const char*, or---even
better---just not give it a local name and pass it directly to std::cout
instead?

[kjellander_webrtc, 2017-05-16 05:44:18]

Noah: no action needed - I found that it was easy to implement --help with just
a couple of lines. I think it makes sense to enforce that for each executable
target.

https://codereview.webrtc.org/2874403003/diff/40001/webrtc/tools/agc/activity...
File webrtc/tools/agc/activity_metric.cc (right):

https://codereview.webrtc.org/2874403003/diff/40001/webrtc/tools/agc/activity...
webrtc/tools/agc/activity_metric.cc:372: std::string usage =
On 2017/05/16 04:10:09, kwiberg-webrtc wrote:
> Wouldn't it make more sense to change this to a const char*, or---even
> better---just not give it a local name and pass it directly to std::cout
> instead?

Right, I changed that now.

[kjellander_webrtc, 2017-05-16 05:44:31]

Description was changed from

==========
Remove gflags dependency for event_log_visualizer and activity_metric

This is the first step towards getting rid of gflags as a dependency.
It has been causing us extra work for a long time since it's not present
in Chromium as one example.

BUG=webrtc:7644
==========

to

==========
Remove gflags dependency for event_log_visualizer and activity_metric

This is the first step towards getting rid of gflags as a dependency.
It has been causing us extra work for a long time since it's not present
in Chromium as one example.

BUG=webrtc:7644
NOTRY=True
==========

[mbonadei, 2017-05-16 06:32:43]

lgtm

[kjellander_webrtc, 2017-05-16 06:58:41]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-05-16 06:58:42]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2874403003/#ps60001 (title:
"Implemented --help flag")

[commit-bot: I haz the power, 2017-05-16 06:58:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-16 07:01:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494917921689690,
"parent_rev": "09f05616757ed8d6215ad5dd5b1eb270625c1a7c", "commit_rev":
"4fa5be451f8a046845bff45bca604badd8ca0fc4"}

[commit-bot: I haz the power, 2017-05-16 07:01:28]

Description was changed from

==========
Remove gflags dependency for event_log_visualizer and activity_metric

This is the first step towards getting rid of gflags as a dependency.
It has been causing us extra work for a long time since it's not present
in Chromium as one example.

BUG=webrtc:7644
NOTRY=True
==========

to

==========
Remove gflags dependency for event_log_visualizer and activity_metric

This is the first step towards getting rid of gflags as a dependency.
It has been causing us extra work for a long time since it's not present
in Chromium as one example.

BUG=webrtc:7644
NOTRY=True

Review-Url: https://codereview.webrtc.org/2874403003
Cr-Commit-Position: refs/heads/master@{#18157}
Committed:
https://chromium.googlesource.com/external/webrtc/+/4fa5be451f8a046845bff45bc...
==========

[commit-bot: I haz the power, 2017-05-16 07:01:28]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/4fa5be451f8a046845bff45bc...