Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2873223004: Orphan headers should check only added files (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Orphan headers should check only added files This CL makes the presubmit check less strict. We can modify untracked headers but we cannot added them anymore. In the meatime I am spawning a lot of bugs to fix the currently untracked headers. BUG=webrtc:7514 NOTRY=True TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2873223004 Cr-Commit-Position: refs/heads/master@{#18080} Committed: https://chromium.googlesource.com/external/webrtc/+/a644ad3280b52bd3000a94abf0dd1538b8c1ff09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2873223004/1
3 years, 7 months ago (2017-05-10 12:19:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/a644ad3280b52bd3000a94abf0dd1538b8c1ff09
3 years, 7 months ago (2017-05-10 12:21:59 UTC) #6
kjellander_webrtc
3 years, 7 months ago (2017-05-10 13:50:03 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698