Delete unused features of AsyncInvoke.

Delete unused features of AsyncInvoke.

Also eliminates its dependency on callback.h.

BUG=None

Review-Url: https://codereview.webrtc.org/2871403003
Cr-Commit-Position: refs/heads/master@{#18163}
Committed: https://chromium.googlesource.com/external/webrtc/+/c4a3173db0359b6b246ac07b5bd3bdbcc51680b0

[pthatcher1, 2017-05-11 15:17:16]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2017-05-11 15:17:17]

lgtm

[nisse-webrtc, 2017-05-12 06:27:49]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 06:27:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-05-12 06:32:34]

nisse@webrtc.org changed reviewers:
+ magjed@webrtc.org

[nisse-webrtc, 2017-05-12 06:32:34]

Magnus, you've been working with this class recently. Would you like to have a
look before I delete the unused invoke-with-callback feature?

[commit-bot: I haz the power, 2017-05-12 06:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:47:39]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-05-15 10:29:42]

On 2017/05/12 06:32:34, nisse-webrtc wrote:
> Magnus, you've been working with this class recently. Would you like to have a
> look before I delete the unused invoke-with-callback feature?

No, if it's unused let's delete it! lgtm

[nisse-webrtc, 2017-05-16 12:31:15]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-05-16 12:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2871403003/#ps20001 (title:
"Rebased.")

[commit-bot: I haz the power, 2017-05-16 12:31:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-16 12:51:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494937875572980,
"parent_rev": "1d7392a45c95794b385f6a7c3a9dfa5428c4bbed", "commit_rev":
"c4a3173db0359b6b246ac07b5bd3bdbcc51680b0"}

[commit-bot: I haz the power, 2017-05-16 12:51:32]

Description was changed from

==========
Delete unused features of AsyncInvoke.

Also eliminates its dependency on callback.h.

BUG=None
==========

to

==========
Delete unused features of AsyncInvoke.

Also eliminates its dependency on callback.h.

BUG=None

Review-Url: https://codereview.webrtc.org/2871403003
Cr-Commit-Position: refs/heads/master@{#18163}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c4a3173db0359b6b246ac07b5...
==========

[commit-bot: I haz the power, 2017-05-16 12:51:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c4a3173db0359b6b246ac07b5...

[Taylor Brandstetter, 2017-05-17 18:25:28]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-05-17 18:25:29]

https://codereview.webrtc.org/2871403003/diff/20001/webrtc/base/thread_unitte...
File webrtc/base/thread_unittest.cc (left):

https://codereview.webrtc.org/2871403003/diff/20001/webrtc/base/thread_unitte...
webrtc/base/thread_unittest.cc:521: }
Sorry for the late feedback, but these tests need to be replaced by equivalent
tests that do the same thing (calling AsyncInvoke from an invoked task), just
without using the method being removed. This is definitely a way AsyncInvoker is
being used in practice, so we should have tests for it. One of these tests was
failing due to an actual bug I'm trying to fix
(https://codereview.webrtc.org/2876273002/).

[Taylor Brandstetter, 2017-05-17 21:15:06]

https://codereview.webrtc.org/2871403003/diff/20001/webrtc/base/thread_unitte...
File webrtc/base/thread_unittest.cc (left):

https://codereview.webrtc.org/2871403003/diff/20001/webrtc/base/thread_unitte...
webrtc/base/thread_unittest.cc:521: }
On 2017/05/17 18:25:28, Taylor Brandstetter wrote:
> Sorry for the late feedback, but these tests need to be replaced by equivalent
> tests that do the same thing (calling AsyncInvoke from an invoked task), just
> without using the method being removed. This is definitely a way AsyncInvoker
is
> being used in practice, so we should have tests for it. One of these tests was
> failing due to an actual bug I'm trying to fix
> (https://codereview.webrtc.org/2876273002/).

Here's a CL that adds a test that does what I'm talking about:
https://codereview.webrtc.org/2885143006/