AppRTCMobile support to turn off the WebRTC AGC and HPF

AppRTCMobile support to turn off the WebRTC AGC and HPF

This CL adds support for turning off the WebRTC AGC 
and HPF in AppRTCMobile.

BUG=webrtc:6183, webrtc:6220
Review-Url: https://codereview.webrtc.org/2871393002
Cr-Commit-Position: refs/heads/master@{#18204}
Committed: https://chromium.googlesource.com/external/webrtc/+/b274204feb562f45bf23badf59104c232defb098

[peah-webrtc, 2017-05-11 14:30:57]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 14:31:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-11 14:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:36:30]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16951)

[peah-webrtc, 2017-05-12 05:19:59]

Description was changed from

==========
AgcExperiment


AgcExperiment

BUG=
==========

to

==========
Experiment code for turning off the WebRTC AGC and HPF on mobiles

BUG=webrtc:6183,webrtc:6220
==========

[peah-webrtc, 2017-05-12 07:50:21]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2017-05-12 07:50:29]

Patchset #1 (id:20001) has been deleted

[peah-webrtc, 2017-05-12 08:15:45]

Patchset #1 (id:40001) has been deleted

[peah-webrtc, 2017-05-12 08:27:38]

Description was changed from

==========
Experiment code for turning off the WebRTC AGC and HPF on mobiles

BUG=webrtc:6183,webrtc:6220
==========

to

==========
AppRTCMobile support to turn off the WebRTC AGC and HPF

This CL adds support for turning off the WebRTC AGC 
and HPF in AppRTCMobile.

BUG=webrtc:6183,webrtc:6220
==========

[peah-webrtc, 2017-05-12 08:28:02]

peah@webrtc.org changed reviewers:
+ sakal@webrtc.org

[peah-webrtc, 2017-05-12 08:28:02]

Hi,
Could you please take a look at this CL?

[sakal, 2017-05-12 08:53:35]

Looks good apart from seemingly unrelated changes to the iOS code.

https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right):

https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:30: NSString *const
kRTCFieldTrialStandaloneLevelControlProfileKey =
@"WebRTC-Audio-DisableAgcOnMobile";
I think this change should be in an another CL.

https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h (right):

https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h:22: RTC_EXTERN
NSString* const kRTCFieldTrialStandaloneLevelControlProfileKey;
ditto

[peah-webrtc, 2017-05-12 09:15:38]

On 2017/05/12 08:53:35, sakal wrote:
> Looks good apart from seemingly unrelated changes to the iOS code.
> 
>
https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
> File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right):
> 
>
https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
> webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:30: NSString *const
> kRTCFieldTrialStandaloneLevelControlProfileKey =
> @"WebRTC-Audio-DisableAgcOnMobile";
> I think this change should be in an another CL.
> 
>
https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
> File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h (right):
> 
>
https://codereview.webrtc.org/2871393002/diff/60001/webrtc/sdk/objc/Framework...
> webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h:22: RTC_EXTERN
> NSString* const kRTCFieldTrialStandaloneLevelControlProfileKey;
> ditto

Ah, sorry about that. You are definitely right! I removed those.
PTAL

[sakal, 2017-05-12 09:20:06]

lgtm

[peah-webrtc, 2017-05-16 14:06:46]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2017-05-16 14:06:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-16 14:11:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 14:11:45]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17075)

[peah-webrtc, 2017-05-17 04:32:11]

peah@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[peah-webrtc, 2017-05-17 04:32:11]

+kjellander as being an OWNER

kjellander@: Could you please take a look at this CL. sakal@ has reviewed was
not an OWNER of the files.

[peah-webrtc, 2017-05-17 04:37:10]

peah@webrtc.org changed reviewers:
+ perkj@webrtc.org
- kjellander@webrtc.org

[peah-webrtc, 2017-05-17 04:37:10]

-kjellander@
Sorry, think I chose an OWNER with .*py ownership
+perkj@ as an OWNER
perkj@:Could you please take a look at this CL?

[Per K, 2017-05-18 09:16:02]

perkj@google.com changed reviewers:
+ perkj@google.com

[Per K, 2017-05-18 09:16:02]

rs lgtm

[perkj_webrtc, 2017-05-18 09:16:55]

On 2017/05/18 09:16:02, Per K wrote:
> rs lgtm

rs lgtm

[peah-webrtc, 2017-05-18 21:00:19]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2017-05-18 21:00:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 22:09:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495141219983310,
"parent_rev": "93e4522105e9933202d660f20a1d86f0c4972a40", "commit_rev":
"b274204feb562f45bf23badf59104c232defb098"}

[commit-bot: I haz the power, 2017-05-18 22:09:37]

Description was changed from

==========
AppRTCMobile support to turn off the WebRTC AGC and HPF

This CL adds support for turning off the WebRTC AGC 
and HPF in AppRTCMobile.

BUG=webrtc:6183,webrtc:6220
==========

to

==========
AppRTCMobile support to turn off the WebRTC AGC and HPF

This CL adds support for turning off the WebRTC AGC 
and HPF in AppRTCMobile.

BUG=webrtc:6183,webrtc:6220

Review-Url: https://codereview.webrtc.org/2871393002
Cr-Commit-Position: refs/heads/master@{#18204}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b274204feb562f45bf23badf5...
==========

[commit-bot: I haz the power, 2017-05-18 22:09:39]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/b274204feb562f45bf23badf5...