Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2871213002: Roll chromium_revision faace60759..b895cae903 (470521:470551) (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update gtest-parallel. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M DEPS View 1 5 chunks +7 lines, -7 lines 0 comments Download
M tools_webrtc/mb/mb.py View 1 chunk +1 line, -0 lines 2 comments Download
M tools_webrtc/mb/mb_unittest.py View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ehmaldonado_webrtc
3 years, 7 months ago (2017-05-10 19:51:05 UTC) #5
kjellander_webrtc
lgtm https://codereview.webrtc.org/2871213002/diff/20001/tools_webrtc/mb/mb.py File tools_webrtc/mb/mb.py (right): https://codereview.webrtc.org/2871213002/diff/20001/tools_webrtc/mb/mb.py#newcode1092 tools_webrtc/mb/mb.py:1092: '../../third_party/gtest-parallel/gtest-parallel', I guess we'll remove this as soon ...
3 years, 7 months ago (2017-05-10 19:55:19 UTC) #6
ehmaldonado_webrtc
https://codereview.webrtc.org/2871213002/diff/20001/tools_webrtc/mb/mb.py File tools_webrtc/mb/mb.py (right): https://codereview.webrtc.org/2871213002/diff/20001/tools_webrtc/mb/mb.py#newcode1092 tools_webrtc/mb/mb.py:1092: '../../third_party/gtest-parallel/gtest-parallel', On 2017/05/10 19:55:19, kjellander_webrtc wrote: > I guess ...
3 years, 7 months ago (2017-05-10 20:15:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2871213002/20001
3 years, 7 months ago (2017-05-10 20:20:05 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:40:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/a7507ebb1cbec606c127d6db7...

Powered by Google App Engine
This is Rietveld 408576698