Fixing video loopback test with encoder factory.

Fixing video loopback test with encoder factory.

BUG=webrtc:5806
Review-Url: https://codereview.webrtc.org/2870123002
Cr-Commit-Position: refs/heads/master@{#18079}
Committed: https://chromium.googlesource.com/external/webrtc/+/48368ad6c62b7c499c4f953e2c2572bfdbe6169a

[minyue-webrtc, 2017-05-09 15:37:10]

Description was changed from

==========
Fixing video loopback test with encoder factory.

BUG=
==========

to

==========
Fixing video loopback test with encoder factory.

BUG=none
==========

[minyue-webrtc, 2017-05-09 15:37:10]

minyue@webrtc.org changed reviewers:
+ ossu@webrtc.org, stefan@webrtc.org

[minyue-webrtc, 2017-05-09 15:37:54]

Hi,

A small fix to video loopback test is needed due to Oskar's introduction of
encoder factory. PTAL.

[ossu, 2017-05-09 15:45:41]

lgtm. Sorry for missing this one!

You could set the bug to webrtc:5806, since it's part of the injectable audio
encoders work.

https://codereview.webrtc.org/2870123002/diff/1/webrtc/audio/audio_send_strea...
File webrtc/audio/audio_send_stream.cc (right):

https://codereview.webrtc.org/2870123002/diff/1/webrtc/audio/audio_send_strea...
webrtc/audio/audio_send_stream.cc:392: RTC_DCHECK(new_config.encoder_factory);
Might as well move this one just below the check on line 389.

[minyue-webrtc, 2017-05-09 15:59:07]

On 2017/05/09 15:45:41, ossu wrote:
> lgtm. Sorry for missing this one!
> 
> You could set the bug to webrtc:5806, since it's part of the injectable audio
> encoders work.
> 
>
https://codereview.webrtc.org/2870123002/diff/1/webrtc/audio/audio_send_strea...
> File webrtc/audio/audio_send_stream.cc (right):
> 
>
https://codereview.webrtc.org/2870123002/diff/1/webrtc/audio/audio_send_strea...
> webrtc/audio/audio_send_stream.cc:392: RTC_DCHECK(new_config.encoder_factory);
> Might as well move this one just below the check on line 389.

That is not your fault. We don't run this test on bots.

[minyue-webrtc, 2017-05-09 15:59:14]

Description was changed from

==========
Fixing video loopback test with encoder factory.

BUG=none
==========

to

==========
Fixing video loopback test with encoder factory.

BUG=webrtc:5806
==========

[minyue-webrtc, 2017-05-10 09:36:42]

minyue@webrtc.org changed reviewers:
+ sprang@webrtc.org

[minyue-webrtc, 2017-05-10 09:37:13]

On 2017/05/09 15:59:07, minyue-webrtc wrote:
> On 2017/05/09 15:45:41, ossu wrote:
> > lgtm. Sorry for missing this one!
> > 
> > You could set the bug to webrtc:5806, since it's part of the injectable
audio
> > encoders work.
> > 
> >
>
https://codereview.webrtc.org/2870123002/diff/1/webrtc/audio/audio_send_strea...
> > File webrtc/audio/audio_send_stream.cc (right):
> > 
> >
>
https://codereview.webrtc.org/2870123002/diff/1/webrtc/audio/audio_send_strea...
> > webrtc/audio/audio_send_stream.cc:392:
RTC_DCHECK(new_config.encoder_factory);
> > Might as well move this one just below the check on line 389.
> 
> That is not your fault. We don't run this test on bots.

+Erik

Stefan is OOO. Erik, would you approve this CL?

[sprang_webrtc, 2017-05-10 10:43:55]

lgtm

[minyue-webrtc, 2017-05-10 10:44:26]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2017-05-10 10:44:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-10 11:06:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494413066665000, "parent_rev":
"8e3bf36a08e21e2c3e765eac5c76eeb6101aeedf", "commit_rev":
"48368ad6c62b7c499c4f953e2c2572bfdbe6169a"}

[commit-bot: I haz the power, 2017-05-10 11:06:15]

Description was changed from

==========
Fixing video loopback test with encoder factory.

BUG=webrtc:5806
==========

to

==========
Fixing video loopback test with encoder factory.

BUG=webrtc:5806

Review-Url: https://codereview.webrtc.org/2870123002
Cr-Commit-Position: refs/heads/master@{#18079}
Committed:
https://chromium.googlesource.com/external/webrtc/+/48368ad6c62b7c499c4f953e2...
==========

[commit-bot: I haz the power, 2017-05-10 11:06:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/48368ad6c62b7c499c4f953e2...