Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2869863003: Remove temporary include of builtin_audio_encoder_factory.h. (Closed)

Created:
3 years, 7 months ago by ossu
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove temporary include of builtin_audio_encoder_factory.h. Add the include to the files where it is actually used instead. BUG=webrtc:5806 Review-Url: https://codereview.webrtc.org/2869863003 Cr-Commit-Position: refs/heads/master@{#18176} Committed: https://chromium.googlesource.com/external/webrtc/+/6488ea424ab771adb061a839bd657b2615cfd35c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/pc/peerconnectionendtoend_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
ossu
PTAL. This change is pretty straight-forward, although it depends on https://codereview.chromium.org/2808743004/ landing first.
3 years, 7 months ago (2017-05-10 15:14:09 UTC) #7
kwiberg-webrtc
lgtm!
3 years, 7 months ago (2017-05-10 15:15:52 UTC) #9
Taylor Brandstetter
lgtm
3 years, 7 months ago (2017-05-11 04:44:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2869863003/1
3 years, 7 months ago (2017-05-17 09:44:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2869863003/1
3 years, 7 months ago (2017-05-17 10:57:24 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 11:39:42 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6488ea424ab771adb061a839b...

Powered by Google App Engine
This is Rietveld 408576698