Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by magjed_webrtc Modified:
3 years, 7 months ago Reviewers:
tommi, kthelgason, tkchin_webrtc CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, sakal, daniela-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionTune ObjC clang-format configuration
This CL sets some options for ObjC in the .clang-format file to closer
match our style guide.
NOTRY=True
BUG=webrtc:7406
Review-Url: https://codereview.webrtc.org/2869593002
Cr-Commit-Position: refs/heads/master@{#18092}
Committed: https://chromium.googlesource.com/external/webrtc/+/198a9300cd26b437800eb708940064f5d1786d9c
Patch Set 1 #
Created: 3 years, 7 months ago
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Configure ObjC clang-format style This CL sets some options in the .clang-format for ObjC to closer match our style guide. BUG=None ========== to ========== Configure ObjC clang-format style This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 ==========
Description was changed from ========== Configure ObjC clang-format style This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 ========== to ========== Configure ObjC clang-format style This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 ==========
Description was changed from ========== Configure ObjC clang-format style This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 ========== to ========== Tune ObjC clang-format configuration This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 ==========
magjed@webrtc.org changed reviewers: + tkchin@webrtc.org
Please take a look.
magjed@webrtc.org changed reviewers: + kthelgason@webrtc.org
Kári - please take a look.
On 2017/05/09 09:08:47, magjed_webrtc wrote: > Kári - please take a look. rs-lgtm. I don't know exactly what the styleguide says, but there is nothing there that looks wrong to me.
lgtm good luck! It will sometimes choke on some bad cases still. Recommend not nesting blocks - that's when you'll see the worst of it. Should still be an overall win though.
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16888)
magjed@webrtc.org changed reviewers: + tommi@webrtc.org
Tommi - please review for ownership approval.
lgtm
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494493904047200, "parent_rev":
"221cc56684a7497e92a6c55f51ffcb339ea3da84", "commit_rev":
"198a9300cd26b437800eb708940064f5d1786d9c"}
Message was sent while issue was closed.
Description was changed from ========== Tune ObjC clang-format configuration This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 ========== to ========== Tune ObjC clang-format configuration This CL sets some options for ObjC in the .clang-format file to closer match our style guide. NOTRY=True BUG=webrtc:7406 Review-Url: https://codereview.webrtc.org/2869593002 Cr-Commit-Position: refs/heads/master@{#18092} Committed: https://chromium.googlesource.com/external/webrtc/+/198a9300cd26b437800eb7089... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/198a9300cd26b437800eb7089... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
