Break backwards traversal loop if we have looped around all packet in the PacketBuffer for H264 fra…

Break backwards traversal loop if we have looped around all packets in the PacketBuffer for H264 frames.

BUG=webrtc:7532
Review-Url: https://codereview.webrtc.org/2868723003
Cr-Commit-Position: refs/heads/master@{#18191}
Committed: https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644df479093b46a96af

[philipel, 2017-05-08 11:27:54]

Description was changed from

==========
Break backwards traversal loop if we have looped around all packet in the
PacketBuffer for H264 frames.

BUG=webrtc:7532
==========

to

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532
==========

[philipel, 2017-05-08 11:28:47]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-05-08 11:47:27]

https://codereview.webrtc.org/2868723003/diff/1/webrtc/modules/video_coding/p...
File webrtc/modules/video_coding/packet_buffer.cc (right):

https://codereview.webrtc.org/2868723003/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet_buffer.cc:201: while (packets_tested < size_
&& PotentialNewFrame(seq_num)) {
Can this perhaps also be a for loop?

https://codereview.webrtc.org/2868723003/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet_buffer.cc:218: while (true) {
Try to get rid of this while loop as it's hard to be sure it doesn't result in
infinite loops. Should be enough with only looping through the packet buffer
once, right?

[philipel, 2017-05-08 12:56:23]

https://codereview.webrtc.org/2868723003/diff/1/webrtc/modules/video_coding/p...
File webrtc/modules/video_coding/packet_buffer.cc (right):

https://codereview.webrtc.org/2868723003/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet_buffer.cc:201: while (packets_tested < size_
&& PotentialNewFrame(seq_num)) {
On 2017/05/08 11:47:27, stefan-webrtc wrote:
> Can this perhaps also be a for loop?

Done.

https://codereview.webrtc.org/2868723003/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet_buffer.cc:218: while (true) {
On 2017/05/08 11:47:27, stefan-webrtc wrote:
> Try to get rid of this while loop as it's hard to be sure it doesn't result in
> infinite loops. Should be enough with only looping through the packet buffer
> once, right?

Agree that a loop is cleaner, fixed.

[philipel, 2017-05-16 11:27:19]

ping

[stefan-webrtc, 2017-05-17 07:01:11]

lgtm

LGTM % nit

https://codereview.webrtc.org/2868723003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/packet_buffer.cc (right):

https://codereview.webrtc.org/2868723003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/packet_buffer.cc:217: for (size_t j = 0; j < size_ -
1; ++j) {
Comment on the - 1

[philipel, 2017-05-18 09:00:56]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2017-05-18 09:00:56]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2868723003/#ps40001 (title:
"Added comment.")

[commit-bot: I haz the power, 2017-05-18 09:01:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-18 09:24:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495098056192810,
"parent_rev": "7cc881d190b27e57580dfa28c3102626b32fae22", "commit_rev":
"539107175a1595d6b0a75644df479093b46a96af"}

[commit-bot: I haz the power, 2017-05-18 09:24:44]

Description was changed from

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532
==========

to

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532

Review-Url: https://codereview.webrtc.org/2868723003
Cr-Commit-Position: refs/heads/master@{#18191}
Committed:
https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644d...
==========

[commit-bot: I haz the power, 2017-05-18 09:24:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644d...

[philipel2, 2017-05-22 12:11:39]

Description was changed from

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532

Review-Url: https://codereview.webrtc.org/2868723003
Cr-Commit-Position: refs/heads/master@{#18191}
Committed:
https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644d...
==========

to

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532, chromium:724031

Review-Url: https://codereview.webrtc.org/2868723003
Cr-Commit-Position: refs/heads/master@{#18191}
Committed:
https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644d...
==========

[philipel2, 2017-05-22 12:11:52]

Description was changed from

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532, chromium:724031

Review-Url: https://codereview.webrtc.org/2868723003
Cr-Commit-Position: refs/heads/master@{#18191}
Committed:
https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644d...
==========

to

==========
Break backwards traversal loop if we have looped around all packets in the
PacketBuffer for H264 frames.

BUG=webrtc:7532

Review-Url: https://codereview.webrtc.org/2868723003
Cr-Commit-Position: refs/heads/master@{#18191}
Committed:
https://chromium.googlesource.com/external/webrtc/+/539107175a1595d6b0a75644d...
==========