Fix webrtcsdp_unittest.

Fix webrtcsdp_unittest.

The test contained an invalid IPv6 address. It should have ":" instead of "::" as separation.

BUG=webrtc:7565
Review-Url: https://codereview.webrtc.org/2868453002
Cr-Commit-Position: refs/heads/master@{#18035}
Committed: https://chromium.googlesource.com/external/webrtc/+/121cabbaa6df33d74e78167004cbb39b2c12dabe

[ehmaldonado_webrtc, 2017-05-05 13:46:15]

Description was changed from

==========
Fix webrtcsdp_unittest.

BUG=webrtc:7565
==========

to

==========
Fix webrtcsdp_unittest.

The test contained an invalid IPv6 address. It should have ":" instead of "::"
as separation.

BUG=webrtc:7565
==========

[ehmaldonado_webrtc, 2017-05-05 13:47:42]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org, perkj@webrtc.org

[ehmaldonado_webrtc, 2017-05-05 13:48:53]

Or at least I think it's not a valid IPv6 address...

[ehmaldonado_webrtc, 2017-05-05 14:08:00]

ehmaldonado@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-05-05 17:51:10]

lgtm. But how was the test passing before, and how is this related to the linked
bug? Should we test that parsing an invalid address such as this fails?

[ehmaldonado_webrtc, 2017-05-05 18:39:24]

On 2017/05/05 17:51:10, Taylor Brandstetter wrote:
> lgtm. But how was the test passing before, and how is this related to the
linked
> bug? Should we test that parsing an invalid address such as this fails?

How was the test passing before?
I don't know. It doesn't seem to care if the IP address was correct or not (I
modified the code so that [1] always returns 0, and modified the IP address to
be "abcd", and the tests still passes).

How is this related to the bug?
In this test we eventually get to [2]
There, we count the number of ':'. Since it's an invalid IPv6 address, there are
too many of them, so that in [3] we subtract too much from the end, and end up
before the beginning. Thus the stack underflow.

Should we test that parsing an invalid address such as this fails?
Yes, definitely.

[1] https://cs.chromium.org/chromium/src/third_party/webrtc/base/win32.cc?l=201
[2] https://cs.chromium.org/chromium/src/third_party/webrtc/base/win32.cc?l=272
[3] https://cs.chromium.org/chromium/src/third_party/webrtc/base/win32.cc?l=279

[ehmaldonado_webrtc, 2017-05-05 18:39:40]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-05-05 18:39:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-05 19:04:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494009580079730, "parent_rev":
"299c8e0161960db39385e50f364834dd02e8ded7", "commit_rev":
"121cabbaa6df33d74e78167004cbb39b2c12dabe"}

[commit-bot: I haz the power, 2017-05-05 19:04:41]

Description was changed from

==========
Fix webrtcsdp_unittest.

The test contained an invalid IPv6 address. It should have ":" instead of "::"
as separation.

BUG=webrtc:7565
==========

to

==========
Fix webrtcsdp_unittest.

The test contained an invalid IPv6 address. It should have ":" instead of "::"
as separation.

BUG=webrtc:7565

Review-Url: https://codereview.webrtc.org/2868453002
Cr-Commit-Position: refs/heads/master@{#18035}
Committed:
https://chromium.googlesource.com/external/webrtc/+/121cabbaa6df33d74e7816700...
==========

[commit-bot: I haz the power, 2017-05-05 19:04:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/121cabbaa6df33d74e7816700...