Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2868443002: Enable LSan leak checking for ASan bots. (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable LSan leak checking for ASan bots. We seem to have lost the LSan leak detection when we migrated our tests to Swarming last year. Too many layers of wrapping scripts are involved in this BUG=chromium:718839 NOTRY=True Review-Url: https://codereview.webrtc.org/2868443002 Cr-Commit-Position: refs/heads/master@{#18032} Committed: https://chromium.googlesource.com/external/webrtc/+/461a560f22a5246f479f861db7178b7546d55b73

Patch Set 1 : Removing all LSan suppressions (proves it wasn't enabled) #

Patch Set 2 : Turning on LSan #

Patch Set 3 : Removing deleted suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools-webrtc/mb/mb.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools-webrtc/mb/mb_unittest.py View 1 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kjellander_webrtc
As I hoped for, we didn't have any leaks. My series of patch set 1-3 ...
3 years, 7 months ago (2017-05-05 13:18:29 UTC) #3
ehmaldonado_webrtc
On 2017/05/05 13:18:29, kjellander_webrtc wrote: > As I hoped for, we didn't have any leaks. ...
3 years, 7 months ago (2017-05-05 13:36:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2868443002/40001
3 years, 7 months ago (2017-05-05 13:36:46 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 13:39:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/461a560f22a5246f479f861db...

Powered by Google App Engine
This is Rietveld 408576698