Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 2868413004: JNI wrapper for PeerConnection::SetBitrate. (Closed)

Created:
3 years, 7 months ago by Zach Stein
Modified:
3 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

JNI wrapper for PeerConnection::SetBitrate. BUG=webrtc:7395 Review-Url: https://codereview.webrtc.org/2868413004 Cr-Commit-Position: refs/heads/master@{#19243} Committed: https://chromium.googlesource.com/external/webrtc/+/d89b0bcc8ab9866f3c783492b9748a388a9aaccc

Patch Set 1 #

Patch Set 2 : Use !IsNull instead of != NULL #

Patch Set 3 : Remove native stub now that real implementation has been submitted. #

Patch Set 4 : Comment for Java method. #

Patch Set 5 : Add back SmallTest import and rebase. #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M webrtc/sdk/android/api/org/webrtc/PeerConnection.java View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnection_jni.cc View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Zach Stein
PTAL
3 years, 4 months ago (2017-08-01 20:29:49 UTC) #7
magjed_webrtc
lgtm
3 years, 4 months ago (2017-08-03 12:34:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2868413004/80001
3 years, 4 months ago (2017-08-03 17:04:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/6558)
3 years, 4 months ago (2017-08-03 17:25:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2868413004/100001
3 years, 4 months ago (2017-08-03 17:38:47 UTC) #15
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 18:11:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/d89b0bcc8ab9866f3c783492b...

Powered by Google App Engine
This is Rietveld 408576698