Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1918)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2867713003: Remove hardcoded kValueSizeBytes values from variable-length header extensions. (Closed)
Patch Set: Patch 1 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 10c947bd845a1080e58f8a52c0b2bcdb17045d45..90c1a526fd539434448d85373c3925c947d2c481 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -128,7 +128,10 @@ class RtpRtcp : public Module {
// Returns max payload length.
// Does not account for RTP headers and FEC/ULP/RED overhead (when FEC is
// enabled).
- virtual size_t MaxPayloadSize() const = 0;
+ // |extension_sizes| is used to to calculate the RTP header extension
+ // overhead and should have an entry for each header extension used.
+ virtual size_t MaxPayloadSize(
danilchap 2017/05/09 12:33:49 This function look unused [and only slightly teste
erikvarga1 2017/05/09 13:30:30 Alright, I've removed it.
+ rtc::ArrayView<const RtpExtensionSize> extension_sizes) const = 0;
// Returns max RTP packet size. Takes into account RTP headers and
// FEC/ULP/RED overhead (when FEC is enabled).

Powered by Google App Engine
This is Rietveld 408576698