Remove hardcoded kValueSizeBytes values from variable-length header extensions.

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 110 matching lines @@
     SetMaxRtpPacketSize(size);
     return 0;
   }
 
   // Sets the maximum size of an RTP packet, including RTP headers.
   virtual void SetMaxRtpPacketSize(size_t size) = 0;
 
   // Returns max payload length.
   // Does not account for RTP headers and FEC/ULP/RED overhead (when FEC is
   // enabled).
-  virtual size_t MaxPayloadSize() const = 0;
+  // |extension_sizes| is used to to calculate the RTP header extension
+  // overhead and should have an entry for each header extension used.
+  virtual size_t MaxPayloadSize(

[danilchap, 2017/05/09 12:33:49]

This function look unused [and only slightly tested] - may be better delete it
rather than complicate it.

[erikvarga1, 2017/05/09 13:30:30]

Alright, I've removed it.

+      rtc::ArrayView<const RtpExtensionSize> extension_sizes) const = 0;
 
   // Returns max RTP packet size. Takes into account RTP headers and
   // FEC/ULP/RED overhead (when FEC is enabled).
   virtual size_t MaxRtpPacketSize() const = 0;
 
   // Sets codec name and payload type. Returns -1 on failure else 0.
   virtual int32_t RegisterSendPayload(const CodecInst& voice_codec) = 0;
 
   // Sets codec name and payload type. Return -1 on failure else 0.
   virtual int32_t RegisterSendPayload(const VideoCodec& video_codec) = 0;
@@ skipping 324 matching lines @@
   virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
 
   // Sends a request for a keyframe.
   // Returns -1 on failure else 0.
   virtual int32_t RequestKeyFrame() = 0;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_