Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2867653002: Fixing invalid IPv6 address parsing stack underflow on Windows. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing invalid IPv6 address parsing stack underflow on Windows. Occurred when parsing an address with more than 7 colons. For example: 1::2:3:4:5:6:7::8 BUG=webrtc:7592 Review-Url: https://codereview.webrtc.org/2867653002 Cr-Commit-Position: refs/heads/master@{#18054} Committed: https://chromium.googlesource.com/external/webrtc/+/966963ac7d62bdac051eacae234495fd355919e6

Patch Set 1 #

Patch Set 2 : Fixing typo. #

Patch Set 3 : Fixing issue caught by new test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M webrtc/base/win32.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/base/win32_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
PTAL
3 years, 7 months ago (2017-05-07 22:26:32 UTC) #2
ehmaldonado_webrtc
On 2017/05/07 22:26:32, Taylor Brandstetter wrote: > PTAL LGTM, thanks!
3 years, 7 months ago (2017-05-08 09:47:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2867653002/40001
3 years, 7 months ago (2017-05-08 17:53:43 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:36:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/966963ac7d62bdac051eacae2...

Powered by Google App Engine
This is Rietveld 408576698