Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2866493002: Allow Windows to return a monitor out of the first quadrant (Closed)

Created:
3 years, 7 months ago by Hzj_jie
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Allow Windows to return a monitor out of the first quadrant Windows may return a DesktopCoordinate out of the first quadrant (x >= 0 && y >= 0), this typically happens when the primary and secondary monitors are swapped. i.e. The secondary monitor is on the left but the primary one is on the right. This change "moves" the entire screen from any quadrant to the (0, 0), so we can capture the monitors in other quadrants. BUG=chromium:715689 Review-Url: https://codereview.webrtc.org/2848443004 Cr-Original-Commit-Position: refs/heads/master@{#17935} Committed: https://chromium.googlesource.com/external/webrtc/+/049ec71e657eef3d15e0f15d60acb1a71e81b521 Review-Url: https://codereview.webrtc.org/2848443004 Cr-Commit-Position: refs/heads/master@{#17938} (cherry picked from commit 419c7427153f3e72ff2a0edf799faf3b1f07c845) Review-Url: https://codereview.webrtc.org/2866493002 . Cr-Commit-Position: refs/branch-heads/59@{#9} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/61fe801ad874104a2d461083f53caee4c19c51b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
M webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h View 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc View 3 chunks +11 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Hzj_jie
3 years, 7 months ago (2017-05-04 18:26:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61fe801ad874104a2d461083f53caee4c19c51b6.

Powered by Google App Engine
This is Rietveld 408576698