Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2866183004: Deleted unused method EstimateMTU, and the WinPing class. (Closed)

Created:
3 years, 7 months ago by nisse-webrtc
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Deleted unused method EstimateMTU, and the WinPing class. BUG=None Review-Url: https://codereview.webrtc.org/2866183004 Cr-Commit-Position: refs/heads/master@{#18077} Committed: https://chromium.googlesource.com/external/webrtc/+/e077ee472a6a14fb78aa59faa4549eea3a227958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -631 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/asyncsocket.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/asyncsocket.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/natsocketfactory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/physicalsocketserver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/physicalsocketserver.cc View 2 chunks +0 lines, -65 lines 0 comments Download
M webrtc/base/socket.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/base/socket_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/base/virtualsocketserver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/virtualsocketserver.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/base/win32_unittest.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M webrtc/base/win32socketserver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/win32socketserver.cc View 2 chunks +0 lines, -32 lines 0 comments Download
D webrtc/base/winping.h View 1 chunk +0 lines, -105 lines 0 comments Download
D webrtc/base/winping.cc View 1 chunk +0 lines, -357 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nisse-webrtc
This code seems to be unused, probably for a long time. Delete?
3 years, 7 months ago (2017-05-09 12:09:00 UTC) #2
pthatcher1
lgtm
3 years, 7 months ago (2017-05-09 23:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2866183004/1
3 years, 7 months ago (2017-05-10 08:54:24 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 08:56:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e077ee472a6a14fb78aa59faa...

Powered by Google App Engine
This is Rietveld 408576698