Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2864303002: Actually move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (Closed)

Created:
3 years, 7 months ago by magjed_webrtc
Modified:
3 years, 7 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Actually move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ The previous reland https://codereview.webrtc.org/2860033002/ didn't actually move CoreVideoFrameBuffer because of a rebase mistake. This CL moves the files. BUG=None Review-Url: https://codereview.webrtc.org/2864303002 Cr-Commit-Position: refs/heads/master@{#18048} Committed: https://chromium.googlesource.com/external/webrtc/+/3149e09156dec38d44dcdbdcf2566d054bfac4f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -162 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/common_video/corevideo_frame_buffer.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 3 chunks +16 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/corevideo_frame_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/objcvideotracksource.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
magjed_webrtc
Kári - please take a look.
3 years, 7 months ago (2017-05-08 09:32:14 UTC) #5
kthelgason
lgtm
3 years, 7 months ago (2017-05-08 10:41:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2864303002/1
3 years, 7 months ago (2017-05-08 10:41:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2864303002/1
3 years, 7 months ago (2017-05-08 12:29:33 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 12:32:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3149e09156dec38d44dcdbdcf...

Powered by Google App Engine
This is Rietveld 408576698