Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2863473005: iOS: Fix runtime error in AppRTCMobile (Closed)

Created:
3 years, 7 months ago by hewwatt
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Fix runtime error in AppRTCMobile bugFix: `poping-up` alert message before `hanging-up` will result in runtime assertation as: [Assert] Trying to dismiss the presentation controller while transitioning already. Warning: Attempt to dismiss from view controller <UINavigationController: 0x13081e200> while a presentation or dismiss is in progress! [Assert] transitionViewForCurrentTransition is not set, presentation controller was dismissed during the presentation? (<_UIAlertControllerAlertPresentationController: 0x12fd57bf0>) BUG=webrtc:7569 Review-Url: https://codereview.webrtc.org/2863473005 Cr-Commit-Position: refs/heads/master@{#18190} Committed: https://chromium.googlesource.com/external/webrtc/+/7cc881d190b27e57580dfa28c3102626b32fae22

Patch Set 1 : Fix runtime error in AppRTCMobile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallViewController.m View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
hewwatt
3 years, 7 months ago (2017-05-04 09:22:14 UTC) #3
kthelgason
lgtm
3 years, 7 months ago (2017-05-04 10:08:03 UTC) #5
magjed_webrtc
lgtm
3 years, 7 months ago (2017-05-04 12:26:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2863473005/1
3 years, 7 months ago (2017-05-18 08:15:13 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 08:33:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7cc881d190b27e57580dfa28c...

Powered by Google App Engine
This is Rietveld 408576698