Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools-webrtc/mb/mb.py

Issue 2862803002: Don't duplicate gtest-parallel flags in gtest-parallel-wrappers. (Closed)
Patch Set: Updated comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools-webrtc/gtest-parallel-wrapper.py ('k') | tools-webrtc/mb/mb_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/mb/mb.py
diff --git a/tools-webrtc/mb/mb.py b/tools-webrtc/mb/mb.py
index 9d568ced126beb08910b49a76f98fd37ac4a3550..a2a593f95988e0a992675f9e86b49251deffdcba 100755
--- a/tools-webrtc/mb/mb.py
+++ b/tools-webrtc/mb/mb.py
@@ -1096,8 +1096,12 @@ class MetaBuildWrapper(object):
output_dir = '${ISOLATED_OUTDIR}' + sep + 'test_logs'
gtest_parallel_wrapper = [
'../../tools-webrtc/gtest-parallel-wrapper.py',
- '--gtest_color=no',
'--output_dir=%s' % output_dir,
+ '--gtest_color=no',
+ # We tell gtest-parallel to interrupt the test after 900 seconds,
+ # so it can exit cleanly and report results, instead of being
+ # interrupted by swarming and not reporting anything.
+ '--timeout=900',
]
asan = 'is_asan=true' in vals['gn_args']
« no previous file with comments | « tools-webrtc/gtest-parallel-wrapper.py ('k') | tools-webrtc/mb/mb_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698