Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2862683002: Merge of Corrected the behavior in AEC3 during buffer overruns and underruns (Closed)

Created:
3 years, 7 months ago by peah-webrtc
Modified:
3 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Merge of Corrected the behavior in AEC3 during buffer overruns and underruns This CL contains a merge of the cl debaa442ed0317e215706c8c7d91c880e6bd6051 into the branch M59. This CL corrects the behavior in AEC3 during buffer overruns and underruns in three ways. 1) When there is no render signal available (due to a buffering issues, a zero block is inserted instead of the previous render block. This avoids the same block being repeatedly inserted when there are many back-to-back calls. 2) The internal counters in the main adaptive filter gain are also reset when the filter is reset. 3) The internal counters in the shadow adaptive filter gain are reset when the filter is reset. NOTRY=true NOPRESUBMIT=true BUG=chromium:717920, webrtc:7559 Review-Url: https://codereview.webrtc.org/2862533002 Cr-Commit-Position: refs/heads/master@{#17991} (cherry picked from commit debaa442ed0317e215706c8c7d91c880e6bd6051) Review-Url: https://codereview.webrtc.org/2862683002 Cr-Commit-Position: refs/branch-heads/59@{#7} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/01b3df3c4dab1e3b2708fe16ddfada56ca9ccfec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M webrtc/modules/audio_processing/aec3/main_filter_update_gain.cc View 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/render_delay_buffer.cc View 4 chunks +17 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/shadow_filter_update_gain.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/shadow_filter_update_gain.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/subtractor.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
peah-webrtc
Hi, This is a merge of an AEC3 bugfix into M59. Could you please review?
3 years, 7 months ago (2017-05-03 20:57:05 UTC) #2
hlundin-webrtc
lgtm
3 years, 7 months ago (2017-05-04 06:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2862683002/1
3 years, 7 months ago (2017-05-04 06:49:01 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-05-04 06:49:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2862683002/1
3 years, 7 months ago (2017-05-04 07:03:05 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 07:03:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/01b3df3c4dab1e3b2708fe16d...

Powered by Google App Engine
This is Rietveld 408576698