Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Unified Diff: webrtc/api/OWNERS

Issue 2862343002: Don't add or rename files in webrtc/ and webrtc/api/ without a proper review (Closed)
Patch Set: apply changes suggested by kjellander@ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/OWNERS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/OWNERS
diff --git a/webrtc/api/OWNERS b/webrtc/api/OWNERS
index 3301ecb00b646dd4b8445b21a9f3893146a7fbce..5dc715f2f261437955fe2c70d2061ac63eb43e71 100644
--- a/webrtc/api/OWNERS
+++ b/webrtc/api/OWNERS
@@ -7,7 +7,8 @@ tkchin@webrtc.org
tommi@webrtc.org
deadbeef@webrtc.org
-# These are for the common case of adding or renaming files. If you're doing
-# structural changes, please get a review from a reviewer in this file.
-per-file *.gn=*
-per-file *.gni=*
+# webrtc/api/ has NO blanket exception letting everyone change *.gn
the sun 2017/05/08 10:37:11 Not sure this comment really is required here. Als
kwiberg-webrtc 2017/05/08 12:58:24 OK, I'll remove this comment (and the correspondin
+# and *.gni files in order to add or rename files, since such changes
+# affect our public API.
+per-file *.gn=kjellander@webrtc.org
+per-file *.gni=kjellander@webrtc.org
« no previous file with comments | « webrtc/OWNERS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698