Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2861673006: Don't initiate perodic probing if we don't have a bandwidth estimate. (Closed)

Created:
3 years, 7 months ago by philipel
Modified:
3 years, 7 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't initiate perodic probing if we don't have a bandwidth estimate. BUG=webrtc:7582 Review-Url: https://codereview.webrtc.org/2861673006 Cr-Commit-Position: refs/heads/master@{#18018} Committed: https://chromium.googlesource.com/external/webrtc/+/d1d247fa3cfa5de6b73b737e8ec2d64636c7d83c

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M webrtc/modules/congestion_controller/probe_controller.cc View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/probe_controller_unittest.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipel
PTAL
3 years, 7 months ago (2017-05-04 13:48:51 UTC) #2
stefan-webrtc
Make sure that the start bitrate also sets the estimated bitrate. Doing so you probably ...
3 years, 7 months ago (2017-05-04 13:51:17 UTC) #3
philipel
Now set the start bitrate as the estimated bitrate.
3 years, 7 months ago (2017-05-04 14:51:50 UTC) #4
stefan-webrtc
lgtm
3 years, 7 months ago (2017-05-04 15:04:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861673006/2
3 years, 7 months ago (2017-05-04 15:18:05 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 15:35:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:2) as
https://chromium.googlesource.com/external/webrtc/+/d1d247fa3cfa5de6b73b737e8...

Powered by Google App Engine
This is Rietveld 408576698