Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2861663002: Update decode/render fps stats when calling VideoReceiveStream::GetStats (Closed)

Created:
3 years, 7 months ago by sprang_webrtc
Modified:
3 years, 7 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update decode/render fps stats when calling VideoReceiveStream::GetStats If rate is only update on new frames, the measured rate cannot reach 0. BUG=webrtc:7560 Review-Url: https://codereview.webrtc.org/2861663002 Cr-Commit-Position: refs/heads/master@{#18009} Committed: https://chromium.googlesource.com/external/webrtc/+/948b27538d39bd38c7f9f999b546517fc892d2d1

Patch Set 1 #

Patch Set 2 : Added unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M webrtc/video/receive_statistics_proxy.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sprang_webrtc
3 years, 7 months ago (2017-05-03 14:09:58 UTC) #4
åsapersson
lgtm
3 years, 7 months ago (2017-05-04 09:33:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861663002/20001
3 years, 7 months ago (2017-05-04 09:39:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 09:47:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/948b27538d39bd38c7f9f999b...

Powered by Google App Engine
This is Rietveld 408576698