Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 2861573002: Initial implementation of Android audio playback error handling. (Closed)

Created:
3 years, 7 months ago by AlexG
Modified:
3 years, 7 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Initial implementation of Android audio playback error handling. BUG=b/34128648 Review-Url: https://codereview.webrtc.org/2861573002 Cr-Commit-Position: refs/heads/master@{#18002} Committed: https://chromium.googlesource.com/external/webrtc/+/49c8f26ad1eb04a289f85b97753b8752bc1ea40f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -6 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +19 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 8 chunks +42 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
AlexG
PTAL
3 years, 7 months ago (2017-05-02 23:49:46 UTC) #2
henrika_webrtc
LGTM
3 years, 7 months ago (2017-05-03 09:03:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861573002/1
3 years, 7 months ago (2017-05-03 18:11:17 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:32:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/49c8f26ad1eb04a289f85b977...

Powered by Google App Engine
This is Rietveld 408576698