Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2861123002: Prevent echo likelihood values > 1.0. (Closed)

Created:
3 years, 7 months ago by ivoc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prevent residual echo likelihood values greater than 1.0. The residual echo likelihood should report a likelihood between 0.0 and 1.0. Currently it can happen that echo likelihoods > 1.0 are reported. As a temporary mitigation to stop this, this CL enforces a hard maximum of 1.0 for the echo likelihood while we investigate the issue further. BUG=b/38014838 Review-Url: https://codereview.webrtc.org/2861123002 Cr-Commit-Position: refs/heads/master@{#18030} Committed: https://chromium.googlesource.com/external/webrtc/+/8f94cd34191214d04d5ef72f1d54b7d733f866f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/audio_processing/residual_echo_detector.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ivoc
Hi Per, Please have a look at this small CL to temporarily mitigate the issue ...
3 years, 7 months ago (2017-05-05 11:13:59 UTC) #3
henrika_webrtc
lgtm
3 years, 7 months ago (2017-05-05 11:16:01 UTC) #4
ivoc
Adding hlundin as an alternative reviewer.
3 years, 7 months ago (2017-05-05 11:49:12 UTC) #6
peah-webrtc
lgtm
3 years, 7 months ago (2017-05-05 12:30:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861123002/1
3 years, 7 months ago (2017-05-05 12:32:19 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 12:50:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8f94cd34191214d04d5ef72f1...

Powered by Google App Engine
This is Rietveld 408576698