|
|
Created:
3 years, 7 months ago by ehmaldonado_webrtc Modified:
3 years, 7 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd --retry_failed=3 flag to gtest-parallel.
This means the test will be executed 4 times max, one run and three retries.
BUG=chromium:718339
Review-Url: https://codereview.webrtc.org/2861043002
Cr-Commit-Position: refs/heads/master@{#18028}
Committed: https://chromium.googlesource.com/external/webrtc/+/2a28035627ab93463005d9549b2f47db6600aa69
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org
lgtm, but can you make it clear what this mean? Does it mean it will do three retry attempts in addition to the first failing one i.e. max 4 runs in total, or is it max 3 runs in total?
Description was changed from ========== Add --retry_failed=3 flag to gtest-parallel. BUG=chromium:718339 ========== to ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max. One run and three re-tries. BUG=chromium:718339 ==========
On 2017/05/05 08:32:59, kjellander_webrtc wrote: > lgtm, but can you make it clear what this mean? > Does it mean it will do three retry attempts in addition to the first failing > one i.e. max 4 runs in total, or is it max 3 runs in total? Max. 4 runs in total. One run and three retries.
On 2017/05/05 08:32:59, kjellander_webrtc wrote: > lgtm, but can you make it clear what this mean? > Does it mean it will do three retry attempts in addition to the first failing > one i.e. max 4 runs in total, or is it max 3 runs in total? Max. 4 runs in total. One run and three retries.
Description was changed from ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max. One run and three re-tries. BUG=chromium:718339 ========== to ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max. One run and three retries. BUG=chromium:718339 ==========
Description was changed from ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max. One run and three retries. BUG=chromium:718339 ========== to ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max, one run and three retries. BUG=chromium:718339 ==========
On 2017/05/05 09:37:59, ehmaldonado_webrtc wrote: > On 2017/05/05 08:32:59, kjellander_webrtc wrote: > > lgtm, but can you make it clear what this mean? > > Does it mean it will do three retry attempts in addition to the first failing > > one i.e. max 4 runs in total, or is it max 3 runs in total? > > Max. 4 runs in total. One run and three retries. So, is it OK as is?
On 2017/05/05 11:23:42, ehmaldonado_webrtc wrote: > On 2017/05/05 09:37:59, ehmaldonado_webrtc wrote: > > On 2017/05/05 08:32:59, kjellander_webrtc wrote: > > > lgtm, but can you make it clear what this mean? > > > Does it mean it will do three retry attempts in addition to the first > failing > > > one i.e. max 4 runs in total, or is it max 3 runs in total? > > > > Max. 4 runs in total. One run and three retries. > > So, is it OK as is? yes
On 2017/05/05 11:23:42, ehmaldonado_webrtc wrote: > On 2017/05/05 09:37:59, ehmaldonado_webrtc wrote: > > On 2017/05/05 08:32:59, kjellander_webrtc wrote: > > > lgtm, but can you make it clear what this mean? > > > Does it mean it will do three retry attempts in addition to the first > failing > > > one i.e. max 4 runs in total, or is it max 3 runs in total? > > > > Max. 4 runs in total. One run and three retries. > > So, is it OK as is? yes
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493983876882860, "parent_rev": "3568d8d4d47e9a38d6914261a7c14ec4ee805ed3", "commit_rev": "2a28035627ab93463005d9549b2f47db6600aa69"}
Message was sent while issue was closed.
Description was changed from ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max, one run and three retries. BUG=chromium:718339 ========== to ========== Add --retry_failed=3 flag to gtest-parallel. This means the test will be executed 4 times max, one run and three retries. BUG=chromium:718339 Review-Url: https://codereview.webrtc.org/2861043002 Cr-Commit-Position: refs/heads/master@{#18028} Committed: https://chromium.googlesource.com/external/webrtc/+/2a28035627ab93463005d9549... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/2a28035627ab93463005d9549... |