Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2861003004: Drop deprecated AudioFrameOperations::Scale methods (Closed)

Created:
3 years, 7 months ago by oprypin_webrtc
Modified:
3 years, 7 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop deprecated AudioFrameOperations::Scale method signatures Context: https://codereview.webrtc.org/2739073003/diff/280003/webrtc/audio/utility/audio_frame_operations.h To satisfy cpplint, the signature of the Scale* methods needed to be changed from a reference to a pointer. However, not to break internal users, the old signature was kept temporarily. Now it can be removed because it's not used anymore. BUG=webrtc:5268 Review-Url: https://codereview.webrtc.org/2861003004 Cr-Commit-Position: refs/heads/master@{#18064} Committed: https://chromium.googlesource.com/external/webrtc/+/99d9f61ad77b111de0fb04f0a40b25718643b5e8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M webrtc/audio/utility/audio_frame_operations.h View 1 chunk +0 lines, -10 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
oprypin_webrtc
3 years, 7 months ago (2017-05-08 17:25:46 UTC) #3
henrika_webrtc
You are referring to an issue which is marked as closed. It is not clear ...
3 years, 7 months ago (2017-05-09 08:06:22 UTC) #4
oprypin_webrtc
On 2017/05/09 08:06:22, henrika_webrtc wrote: > You are referring to an issue which is marked ...
3 years, 7 months ago (2017-05-09 08:37:31 UTC) #6
henrika_webrtc
LGTM
3 years, 7 months ago (2017-05-09 09:16:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2861003004/1
3 years, 7 months ago (2017-05-09 09:18:05 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 09:43:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/99d9f61ad77b111de0fb04f0a...

Powered by Google App Engine
This is Rietveld 408576698