Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2860573010: Merge ScreenCapturerWinDirectx::frames_ and contexts_ (Closed)

Created:
3 years, 7 months ago by Hzj_jie
Modified:
3 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Merge ScreenCapturerWinDirectx::frames_ and contexts_ The key change of this CL is to merge ScreenCapturerWinDirectx::frames_ and contexts_ into a new DxgiFrame class. So consumers of DxgiDuplicateController does not need to maintain two objects. DxgiDuplicateController::Duplicate*() functions are also updated to accept DxgiFrame parameter instead of SharedDesktopFrame + Context. The advantages of this change are, 1. Once the screen resolution changes or an existing monitor has been removed, DxgiFrame can automatically reset the frame without needing to return a capture failure. 2. Remove public APIs of DxgiDuplicatorController. Some public APIs are not needed anymore, i.e. consumers of DxgiDuplicatorController do not need to take care about these internal states anymore. It also helps to remove several lock acquiements. 3. Reduce the complexity of ScreenCapturerWinDirectx. But the disadvantage is, instead of a boolean value, DxgiDuplicateController::Duplicate*() now return an enumeration. Clients need to use the enumeration to decide whether the error can be recovered or not. This change also removes a duplicating logic in ScreenCapturerWinDirectx. i.e. ResolutionChangeDetector, DxgiDuplicateController now takes care of the screen resolution changes. I have verified the scenarios with and without SharedMemoryFactory, also the Desktop capture API example. So far no regression is detected. BUG=704205, 715689 Review-Url: https://codereview.webrtc.org/2788863006 Cr-Commit-Position: refs/heads/master@{#17795} (cherry picked from commit cf5753df778c10ec1034076d1f315fd27fad183d) Review-Url: https://codereview.webrtc.org/2860573010 . Cr-Commit-Position: refs/branch-heads/59@{#8} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/b06caae2213badc34c2f244b15676c1cd05f070a

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Hzj_jie
3 years, 7 months ago (2017-05-04 18:25:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b06caae2213badc34c2f244b15676c1cd05f070a.

Powered by Google App Engine
This is Rietveld 408576698