Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 2860353002: When a data channel fails to be created, return nil instead of crashing. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

When a data channel fails to be created, return nil instead of crashing. BUG=webrtc:4619 Review-Url: https://codereview.webrtc.org/2860353002 Cr-Commit-Position: refs/heads/master@{#18034} Committed: https://chromium.googlesource.com/external/webrtc/+/299c8e0161960db39385e50f364834dd02e8ded7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+DataChannel.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
PTAL
3 years, 7 months ago (2017-05-05 08:35:49 UTC) #2
magjed_webrtc
lgtm
3 years, 7 months ago (2017-05-05 09:40:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2860353002/1
3 years, 7 months ago (2017-05-05 16:35:28 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:00:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/299c8e0161960db39385e50f3...

Powered by Google App Engine
This is Rietveld 408576698