DescriptionNetEq: Fix a bug in expand_rate and speech_expand_rate calculation
After a Merge operation, the statistics for number of samples
generated using Expand must be corrected, and the correction can in
fact be negative. However, a bug was introduced in
https://codereview.webrtc.org/1230503003 which uses a size_t to
represent the correction, which leads to wrap-around of the negative
value. This is not a problem in itself, since this value is added to
another size_t, with the effect that the desired subtraction happens
anyway.
The actual problem arises if the statistics are polled/reset before a
subtraction happens -- that is, between an Expand and a Merge
operation. This will lead to an actual wrap-around of the stats value,
and large expand_rate (16384) is reported.
BUG=webrtc:7554
Review-Url: https://codereview.webrtc.org/2859483005
Cr-Commit-Position: refs/heads/master@{#18029}
Committed: https://chromium.googlesource.com/external/webrtc/+/2979f55f95ec71425a32fca31c50c9cbd71ad738
Patch Set 1 #Patch Set 2 : Fix android checksum #
Total comments: 11
Patch Set 3 : After first round of reviews #
Total comments: 1
Patch Set 4 : Changing to Minyue's suggestion #
Total comments: 1
Messages
Total messages: 24 (14 generated)
|