|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by ehmaldonado_webrtc Modified:
3 years, 7 months ago CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix GN errors for Win ASan bots.
BUG=chromium:677380
NOTRY=True
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2858923002
Cr-Commit-Position: refs/heads/master@{#18003}
Committed: https://chromium.googlesource.com/external/webrtc/+/642b0f8ffd269065c1f638d3c116b14e18a2eb82
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org
Looks like it works! The bot is failing because it found an issue for peerconnection_unittests https://chromium-swarm.appspot.com/task?id=35e7b1e3f1392e10&refresh=10&show_r...
Description was changed from ========== stuff BUG= ========== to ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 ==========
kjellander@google.com changed reviewers: + kjellander@google.com
lgtm (please use NOTRY=True)
Description was changed from ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 ========== to ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 NOTRY=True ========== to ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 NOTRY=True TBR=kjellander@webrtc.org ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493841796855720, "parent_rev":
"49c8f26ad1eb04a289f85b97753b8752bc1ea40f", "commit_rev":
"642b0f8ffd269065c1f638d3c116b14e18a2eb82"}
Message was sent while issue was closed.
Description was changed from ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 NOTRY=True TBR=kjellander@webrtc.org ========== to ========== Fix GN errors for Win ASan bots. BUG=chromium:677380 NOTRY=True TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2858923002 Cr-Commit-Position: refs/heads/master@{#18003} Committed: https://chromium.googlesource.com/external/webrtc/+/642b0f8ffd269065c1f638d3c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/642b0f8ffd269065c1f638d3c...
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
