Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2858923002: Fix errors for Win ASan bots. (Closed)

Created:
3 years, 7 months ago by ehmaldonado_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix GN errors for Win ASan bots. BUG=chromium:677380 NOTRY=True TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2858923002 Cr-Commit-Position: refs/heads/master@{#18003} Committed: https://chromium.googlesource.com/external/webrtc/+/642b0f8ffd269065c1f638d3c116b14e18a2eb82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools-webrtc/mb/mb_config.pyl View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
ehmaldonado_webrtc
Looks like it works! The bot is failing because it found an issue for peerconnection_unittests ...
3 years, 7 months ago (2017-05-03 15:27:46 UTC) #2
kjellander (google.com)
lgtm (please use NOTRY=True)
3 years, 7 months ago (2017-05-03 19:44:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2858923002/1
3 years, 7 months ago (2017-05-03 20:01:40 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-03 20:01:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2858923002/1
3 years, 7 months ago (2017-05-03 20:03:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/642b0f8ffd269065c1f638d3c116b14e18a2eb82
3 years, 7 months ago (2017-05-03 20:06:02 UTC) #16
kjellander_webrtc
3 years, 7 months ago (2017-05-03 21:03:43 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698