Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 2858343002: Fixing pseudotcp_parser_fuzzer crash with NO_MAIN_THREAD_WRAPPING. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing pseudotcp_parser_fuzzer crash with NO_MAIN_THREAD_WRAPPING. The test was trying to solve this problem already with AutoThread, but the order of variable declaration was causing it to be created after "rtc::Thread::Current()" was already called. BUG=chromium:701262 TBR=pbos@webrtc.org Review-Url: https://codereview.webrtc.org/2858343002 Cr-Commit-Position: refs/heads/master@{#18019} Committed: https://chromium.googlesource.com/external/webrtc/+/70719a773df8e4ff1af6b8c8e9b6bf24e74ee500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Taylor Brandstetter
3 years, 7 months ago (2017-05-04 18:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2858343002/1
3 years, 7 months ago (2017-05-04 18:56:10 UTC) #5
pbos-webrtc
lgtm
3 years, 7 months ago (2017-05-04 18:56:43 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 19:16:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/70719a773df8e4ff1af6b8c8e...

Powered by Google App Engine
This is Rietveld 408576698