Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2858263002: Blacklisting of HW-AEC/NS and OpenSL must now be done by the WebRTC client (Closed)

Created:
3 years, 7 months ago by henrika_webrtc
Modified:
3 years, 7 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Blacklisting of HW-AEC/NS and OpenSL must now be done by the WebRTC client. BUG=NONE Review-Url: https://codereview.webrtc.org/2858263002 Cr-Commit-Position: refs/heads/master@{#18025} Committed: https://chromium.googlesource.com/external/webrtc/+/999445a1bbda2ebc511d3c86807f2173d3f084a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
henrika_webrtc
Removed possibly conflicting blacklisting in native WebRTC. It is now up to the using client ...
3 years, 7 months ago (2017-05-04 11:59:34 UTC) #3
AlexG
lgtm
3 years, 7 months ago (2017-05-04 17:11:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2858263002/1
3 years, 7 months ago (2017-05-05 09:01:14 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 09:03:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/999445a1bbda2ebc511d3c868...

Powered by Google App Engine
This is Rietveld 408576698