Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2857363002:
Add functionality to clear surface to a specific color in EglRenderer. (Closed)
|
Created:
3 years, 7 months ago by sakal Modified:
3 years, 7 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd functionality to clear surface to a specific color in EglRenderer.
BUG=b/31895311
Review-Url: https://codereview.webrtc.org/2857363002
Cr-Commit-Position: refs/heads/master@{#18013}
Committed: https://chromium.googlesource.com/external/webrtc/+/f25a22041c5b5043ba170dca3c0591bc714991d8
Patch Set 1 : Add functionality to clear surface to a specific color in EglRenderer. #Patch Set 2 : Forward call instead in clearImage(). #Patch Set 3 : Fix. #Messages
Total messages: 21 (16 generated)
Patchset #1 (id:1) has been deleted
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
lgtm
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by sakal@webrtc.org
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sakal@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2857363002/#ps50001 (title: "Fix.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 50001, "attempt_start_ts": 1493903062993420,
"parent_rev": "18ad1d4008ce5a1909310bafdd50897cfefc2de7", "commit_rev":
"f25a22041c5b5043ba170dca3c0591bc714991d8"}
Message was sent while issue was closed.
Description was changed from ========== Add functionality to clear surface to a specific color in EglRenderer. BUG=b/31895311 ========== to ========== Add functionality to clear surface to a specific color in EglRenderer. BUG=b/31895311 Review-Url: https://codereview.webrtc.org/2857363002 Cr-Commit-Position: refs/heads/master@{#18013} Committed: https://chromium.googlesource.com/external/webrtc/+/f25a22041c5b5043ba170dca3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:50001) as https://chromium.googlesource.com/external/webrtc/+/f25a22041c5b5043ba170dca3... |
