Disable CpuTimeTest on instrumented builds.

Disable CpuTimeTest on instrumented builds.

The test relies on the ability to run a thread for a controllable
duration of time, which is unreliable on instrumented builds (TSan,
etc.).

Also adding a minimal test which can still be run on instrumented builds, so
they at least still exercise the code.

BUG=webrtc:7542
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2856473002
Cr-Commit-Position: refs/heads/master@{#17961}
Committed: https://chromium.googlesource.com/external/webrtc/+/7311b246609973ae3980a747999e62e025e1e75f

[Taylor Brandstetter, 2017-04-30 18:14:59]

deadbeef@webrtc.org changed reviewers:
+ ilnik@webrtc.org, kjellander@webrtc.org

[Taylor Brandstetter, 2017-04-30 18:14:59]

PTAL

[ilnik, 2017-05-01 11:16:11]

LGTM with nit.

[ilnik, 2017-05-01 11:16:19]

https://codereview.webrtc.org/2856473002/diff/1/webrtc/base/cpu_time_unittest.cc
File webrtc/base/cpu_time_unittest.cc (right):

https://codereview.webrtc.org/2856473002/diff/1/webrtc/base/cpu_time_unittest...
webrtc/base/cpu_time_unittest.cc:60: EXPECT_GT(thread_duration_nanos, 0);
nit: maybe use EXPECT_GE here?

[Taylor Brandstetter, 2017-05-01 17:15:24]

Description was changed from

==========
Disable CpuTimeTest on instrumented builds.

The test relies on the ability to run a thread for a controllable
duration of time, which is unreliable on instrumented builds (TSan,
etc.).

Also adding a minimal test which can still be run on instrumented builds, so
they at least still exercise the code.

BUG=webrtc:7542
==========

to

==========
Disable CpuTimeTest on instrumented builds.

The test relies on the ability to run a thread for a controllable
duration of time, which is unreliable on instrumented builds (TSan,
etc.).

Also adding a minimal test which can still be run on instrumented builds, so
they at least still exercise the code.

BUG=webrtc:7542
TBR=kjellander@webrtc.org
==========

[Taylor Brandstetter, 2017-05-01 17:15:29]

https://codereview.webrtc.org/2856473002/diff/1/webrtc/base/cpu_time_unittest.cc
File webrtc/base/cpu_time_unittest.cc (right):

https://codereview.webrtc.org/2856473002/diff/1/webrtc/base/cpu_time_unittest...
webrtc/base/cpu_time_unittest.cc:60: EXPECT_GT(thread_duration_nanos, 0);
On 2017/05/01 11:16:19, ilnik wrote:
> nit: maybe use EXPECT_GE here?

Done.

[Taylor Brandstetter, 2017-05-01 17:15:32]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-05-01 17:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from ilnik@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2856473002/#ps20001 (title:
"Use EXPECT_GE to be even safer.")

[commit-bot: I haz the power, 2017-05-01 17:15:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-01 17:43:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493658932029940,
"parent_rev": "d7851aad407cab621d677cd47fb1c0ff20396d88", "commit_rev":
"7311b246609973ae3980a747999e62e025e1e75f"}

[commit-bot: I haz the power, 2017-05-01 17:43:47]

Description was changed from

==========
Disable CpuTimeTest on instrumented builds.

The test relies on the ability to run a thread for a controllable
duration of time, which is unreliable on instrumented builds (TSan,
etc.).

Also adding a minimal test which can still be run on instrumented builds, so
they at least still exercise the code.

BUG=webrtc:7542
TBR=kjellander@webrtc.org
==========

to

==========
Disable CpuTimeTest on instrumented builds.

The test relies on the ability to run a thread for a controllable
duration of time, which is unreliable on instrumented builds (TSan,
etc.).

Also adding a minimal test which can still be run on instrumented builds, so
they at least still exercise the code.

BUG=webrtc:7542
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2856473002
Cr-Commit-Position: refs/heads/master@{#17961}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7311b246609973ae3980a7479...
==========

[commit-bot: I haz the power, 2017-05-01 17:43:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7311b246609973ae3980a7479...

[kjellander_webrtc, 2017-05-02 04:14:15]

lgtm