Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2855573004: Unflaking PeerConnectionIntegrationTest.DtmfSenderObserver. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Unflaking PeerConnectionIntegrationTest.DtmfSenderObserver. The test attempted to call InsertDtmf before verifying that the DTLS handshake was complete. Unlike a data channel, the DTMF sender doesn't do any buffering, so this isn't reliable. BUG=webrtc:7547 NOTRY=True Review-Url: https://codereview.webrtc.org/2855573004 Cr-Commit-Position: refs/heads/master@{#18041} Committed: https://chromium.googlesource.com/external/webrtc/+/7145280954d4111230515d06e73f24c6d199b9ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M webrtc/pc/peerconnection_integrationtest.cc View 3 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Taylor Brandstetter
PTAL
3 years, 7 months ago (2017-05-01 23:03:11 UTC) #2
pthatcher1
lgtm
3 years, 7 months ago (2017-05-01 23:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2855573004/1
3 years, 7 months ago (2017-05-07 22:25:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/20257) linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 7 months ago (2017-05-07 23:30:42 UTC) #8
Taylor Brandstetter
On 2017/05/07 23:30:42, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-08 00:18:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2855573004/1
3 years, 7 months ago (2017-05-08 00:18:49 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 00:21:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7145280954d4111230515d06e...

Powered by Google App Engine
This is Rietveld 408576698