Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2855473006: Delete dead code VP8EncoderImpl::UpdateCodecFrameSize. (Closed)

Created:
3 years, 7 months ago by brandtr
Modified:
3 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete dead code VP8EncoderImpl::UpdateCodecFrameSize. BUG=webrtc:7349 Review-Url: https://codereview.webrtc.org/2855473006 Cr-Commit-Position: refs/heads/master@{#17969} Committed: https://chromium.googlesource.com/external/webrtc/+/fc31a43e3652df4c8e03bfff89858c4858d79b89

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove from header too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 2 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
brandtr
3 years, 7 months ago (2017-05-02 07:32:35 UTC) #2
pbos-webrtc
lgtm if you remove it from the header too. :) https://codereview.webrtc.org/2855473006/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (left): https://codereview.webrtc.org/2855473006/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#oldcode773 ...
3 years, 7 months ago (2017-05-02 08:12:33 UTC) #3
brandtr
Thanks. Working late? https://codereview.webrtc.org/2855473006/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (left): https://codereview.webrtc.org/2855473006/diff/1/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc#oldcode773 webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:773: int VP8EncoderImpl::UpdateCodecFrameSize(int width, int height) { ...
3 years, 7 months ago (2017-05-02 08:38:11 UTC) #4
pbos-webrtc
On 2017/05/02 08:38:11, brandtr wrote: > Thanks. Working late? Nah, I'm in MUC right now. ...
3 years, 7 months ago (2017-05-02 08:39:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2855473006/20001
3 years, 7 months ago (2017-05-02 08:52:00 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 09:21:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/fc31a43e3652df4c8e03bfff8...

Powered by Google App Engine
This is Rietveld 408576698