Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2855163003: Add --quick flag to low bandwidth audio test (Closed)

Created:
3 years, 7 months ago by oprypin_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tlegrand-webrtc, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add --quick flag to low bandwidth audio test BUG=webrtc:7229 Review-Url: https://codereview.webrtc.org/2855163003 Cr-Commit-Position: refs/heads/master@{#18010} Committed: https://chromium.googlesource.com/external/webrtc/+/76a1ce71f97e9a4c091ba47c529027d213593421

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M webrtc/audio/test/low_bandwidth_audio_test.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
oprypin_webrtc
3 years, 7 months ago (2017-05-04 09:26:16 UTC) #5
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2855163003/diff/1/webrtc/audio/test/low_bandwidth_audio_test.cc File webrtc/audio/test/low_bandwidth_audio_test.cc (right): https://codereview.webrtc.org/2855163003/diff/1/webrtc/audio/test/low_bandwidth_audio_test.cc#newcode114 webrtc/audio/test/low_bandwidth_audio_test.cc:114: SleepMs(1000); Maybe a comment here explaining what the ...
3 years, 7 months ago (2017-05-04 09:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2855163003/20001
3 years, 7 months ago (2017-05-04 09:35:12 UTC) #9
kjellander_webrtc
Thanks!
3 years, 7 months ago (2017-05-04 09:51:11 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 10:06:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/76a1ce71f97e9a4c091ba47c5...

Powered by Google App Engine
This is Rietveld 408576698