Move RTCAudioSession* files modules/audio_device/ -> sdk/Framework.

Move RTCAudioSession* files  modules/audio_device/ -> sdk/Framework.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2855023003
Cr-Commit-Position: refs/heads/master@{#18443}
Committed: https://chromium.googlesource.com/external/webrtc/+/59ee91b68a44104b9aec7b34ac67a215bbf84f85

[daniela-webrtc, 2017-05-03 12:36:22]

denicija@webrtc.org changed reviewers:
+ henrika@chromium.org, kthelgason@webrtc.org

[daniela-webrtc, 2017-05-03 12:36:23]

Can you please take a look at this CL when you have time.

[henrika_webrtc, 2017-05-03 12:39:20]

Does
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_device/...
still work?

[daniela-webrtc, 2017-05-03 12:57:14]

On 2017/05/03 12:39:20, henrika_webrtc wrote:
> Does
>
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_device/...
> still work?

Yes, it still works with this change. Just tested it out :)

[henrika_webrtc, 2017-05-03 13:01:01]

Then, how can I resist ;-)

LGTM

[tkchin_webrtc, 2017-05-03 16:37:13]

On 2017/05/03 13:01:01, henrika_webrtc wrote:
> Then, how can I resist ;-)
> 
> LGTM

Can you move it to an audio subdirectory instead of directly in Classes/? That
is starting to get really cluttered.

[tkchin_webrtc, 2017-05-03 16:48:21]

tkchin@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2017-05-03 16:48:21]

Might also want to consider a separate directory under UnitTests/ for unit
tests, because the list may grow.

https://codereview.webrtc.org/2855023003/diff/20001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2855023003/diff/20001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:94: rtc_static_library("rtc_sdk_audio_session") {
rtc_sdk_audio?

There may be things in the future we want that aren't related to audio session
specifically.

[daniela-webrtc, 2017-05-04 11:28:46]

On 2017/05/03 16:48:21, tkchin_webrtc wrote:
> Might also want to consider a separate directory under UnitTests/ for unit
> tests, because the list may grow.
> 
> https://codereview.webrtc.org/2855023003/diff/20001/webrtc/sdk/BUILD.gn
> File webrtc/sdk/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2855023003/diff/20001/webrtc/sdk/BUILD.gn#newco...
> webrtc/sdk/BUILD.gn:94: rtc_static_library("rtc_sdk_audio_session") {
> rtc_sdk_audio?
> 
> There may be things in the future we want that aren't related to audio session
> specifically.

In that case I'll wait until https://codereview.webrtc.org/2862543002 lands and
I'll do the changes after.

[daniela-webrtc, 2017-06-02 12:07:34]

The CQ bit was checked by denicija@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 12:07:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-02 12:14:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 12:14:42]

Dry run: Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[daniela-webrtc, 2017-06-02 12:25:44]

The CQ bit was checked by denicija@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 12:25:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-02 12:56:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 12:56:06]

Dry run: This issue passed the CQ dry run.

[daniela-webrtc, 2017-06-02 12:57:43]

Care to take another look at this?

[henrika_webrtc, 2017-06-02 13:09:08]

lgtm++

[kthelgason, 2017-06-02 13:54:07]

just some small nits :)

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/DEPS (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/DEPS:14: "audio_device_unittest_ios\.mm": [
Maybe add a TODO comment here so we don't forget to remove these.

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm:16: #import
"webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSessionConfiguration.h"
ditto

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:88: "objc/Framework/Classes/RTCAudioSessionConfiguration.m",
Can you nest these in an "Audio" folder inside Classes?

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:389: # RTCMTLVideoView not supported on 32-bit arm
This comment now needs to be moved inside the if(is_ios)

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm:14: #include
"webrtc/base/gunit.h"
why did this change?

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm:16: #import
"WebRTC/RTCAudioSession.h"
alphabetize

[daniela-webrtc, 2017-06-02 14:16:45]

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/DEPS (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/DEPS:14: "audio_device_unittest_ios\.mm": [
On 2017/06/02 13:54:06, kthelgason wrote:
> Maybe add a TODO comment here so we don't forget to remove these.

This will probably stay until we refactor this and break the dependency to sdk
:(

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:88: "objc/Framework/Classes/RTCAudioSessionConfiguration.m",
On 2017/06/02 13:54:06, kthelgason wrote:
> Can you nest these in an "Audio" folder inside Classes?

Done.

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/BUILD.gn#newco...
webrtc/sdk/BUILD.gn:389: # RTCMTLVideoView not supported on 32-bit arm
On 2017/06/02 13:54:06, kthelgason wrote:
> This comment now needs to be moved inside the if(is_ios)

Done.

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm (right):

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm:14: #include
"webrtc/base/gunit.h"
On 2017/06/02 13:54:06, kthelgason wrote:
> why did this change?

All objc tests have dependency on base/gunit. There is no dependency on
test/gtest in the sdk build file.

https://codereview.webrtc.org/2855023003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm:16: #import
"WebRTC/RTCAudioSession.h"
On 2017/06/02 13:54:06, kthelgason wrote:
> alphabetize

Done.

[kthelgason, 2017-06-05 12:14:11]

lgtm

[daniela-webrtc, 2017-06-05 12:24:58]

The CQ bit was checked by denicija@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 12:25:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-05 12:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 12:45:50]

Dry run: This issue passed the CQ dry run.

[daniela-webrtc, 2017-06-05 12:46:36]

The CQ bit was checked by denicija@webrtc.org

[daniela-webrtc, 2017-06-05 12:46:37]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2855023003/#ps80001 (title:
"Address comments")

[commit-bot: I haz the power, 2017-06-05 12:46:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-05 12:48:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496666796978310,
"parent_rev": "90d9e10330df10af110b8de3cfc0d813ac1cdfc3", "commit_rev":
"59ee91b68a44104b9aec7b34ac67a215bbf84f85"}

[commit-bot: I haz the power, 2017-06-05 12:48:52]

Description was changed from

==========
Move RTCAudioSession* files  modules/audio_device/ -> sdk/Framework.

BUG=NONE
==========

to

==========
Move RTCAudioSession* files  modules/audio_device/ -> sdk/Framework.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2855023003
Cr-Commit-Position: refs/heads/master@{#18443}
Committed:
https://chromium.googlesource.com/external/webrtc/+/59ee91b68a44104b9aec7b34a...
==========

[commit-bot: I haz the power, 2017-06-05 12:48:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/59ee91b68a44104b9aec7b34a...