Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2854533002: Run clang-format on sigslot.h. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Run clang-format on sigslot.h. It's diverged enough from the original version that we no longer benefit from keeping the old formatting. BUG=NONE Review-Url: https://codereview.webrtc.org/2854533002 Cr-Commit-Position: refs/heads/master@{#18129} Committed: https://chromium.googlesource.com/external/webrtc/+/d0ffa8615d9f0aa5d5e3d17e5cab6ebdddc21846

Patch Set 1 #

Patch Set 2 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -621 lines) Patch
M webrtc/base/sigslot.h View 1 2 chunks +582 lines, -621 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Taylor Brandstetter
PTAL
3 years, 7 months ago (2017-04-29 08:53:06 UTC) #2
pthatcher1
lgtm
3 years, 7 months ago (2017-05-01 23:47:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2854533002/20001
3 years, 7 months ago (2017-05-13 05:28:50 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 05:52:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d0ffa8615d9f0aa5d5e3d17e5...

Powered by Google App Engine
This is Rietveld 408576698