Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2854343002: Remove config.h from //webrtc:webrtc target. (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove config.h from //webrtc:webrtc target. It's already present in //webrtc:webrtc_common BUG=webrtc:5878 NOTRY=True Review-Url: https://codereview.webrtc.org/2854343002 Cr-Commit-Position: refs/heads/master@{#17990} Committed: https://chromium.googlesource.com/external/webrtc/+/5af6e25b106f20c269d00ab33f751c0eff6162ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
I found this old cleanup when going through bugs related to the Slim and Modular ...
3 years, 7 months ago (2017-05-03 11:52:23 UTC) #2
mbonadei
On 2017/05/03 11:52:23, kjellander_webrtc wrote: > I found this old cleanup when going through bugs ...
3 years, 7 months ago (2017-05-03 11:55:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2854343002/1
3 years, 7 months ago (2017-05-03 12:26:34 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 12:28:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5af6e25b106f20c269d00ab33...

Powered by Google App Engine
This is Rietveld 408576698