Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2853283002: Fix lint issues on Android. (Closed)

Created:
3 years, 7 months ago by sakal
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix lint issues on Android. BUG=webrtc:7549 Review-Url: https://codereview.webrtc.org/2853283002 Cr-Commit-Position: refs/heads/master@{#17982} Committed: https://chromium.googlesource.com/external/webrtc/+/44116a5dc5a0c4c450700dbcebffd23875911f35

Patch Set 1 : Address lint suppressions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M tools-webrtc/android/suppressions.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/examples/androidapp/res/layout/activity_connect.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCBluetoothManager.java View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/NetworkMonitor.java View 3 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
sakal
PTAL
3 years, 7 months ago (2017-05-02 14:53:10 UTC) #3
magjed_webrtc
lgtm
3 years, 7 months ago (2017-05-03 09:46:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2853283002/20001
3 years, 7 months ago (2017-05-03 09:47:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16674)
3 years, 7 months ago (2017-05-03 09:52:22 UTC) #13
kjellander_webrtc
On 2017/05/03 09:52:22, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-03 09:53:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2853283002/20001
3 years, 7 months ago (2017-05-03 10:16:58 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 10:19:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/44116a5dc5a0c4c450700dbce...

Powered by Google App Engine
This is Rietveld 408576698