Extract TL config to VP8 libvpx flag conversion.

Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

BUG=chromium:702017, webrtc:7349
R=brandt@webrtc.org

Review-Url: https://codereview.webrtc.org/2849723002
Cr-Commit-Position: refs/heads/master@{#17970}
Committed: https://chromium.googlesource.com/external/webrtc/+/fa18e25461c258dca30bd3c382863411f8c3b77b

[pbos-webrtc, 2017-04-27 23:57:14]

PTAL, I kept the flag conversion for unittests to prevent a significant rewrite
that would make this being a no-op harder to understand.

If this is not OK, can I do the unittest rewrite in a separate CL?

[pbos-webrtc, 2017-04-27 23:59:07]

Description was changed from

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

R=sprang@webrtc.org
BUG=chromium:702017,webrtc:7349
==========

to

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

R=stefan@webrtc.org
BUG=chromium:702017,webrtc:7349
==========

[pbos-webrtc, 2017-04-27 23:59:07]

pbos@webrtc.org changed reviewers:
+ stefan@webrtc.org
- sprang@webrtc.org

[pbos-webrtc, 2017-04-27 23:59:22]

Eh, sprang@ being OOO, can you take a look stefan@?

[pbos-webrtc, 2017-04-28 18:51:04]

Description was changed from

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

R=stefan@webrtc.org
BUG=chromium:702017,webrtc:7349
==========

to

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

BUG=chromium:702017,webrtc:7349
R=stefan@webrtc.org,sprang@webrtc.org
==========

[pbos-webrtc, 2017-04-28 18:51:04]

pbos@webrtc.org changed reviewers:
+ sprang@webrtc.org

[pbos-webrtc, 2017-04-28 18:51:14]

.. or sprang@ whoever comes first.

[brandtr, 2017-05-02 09:03:43]

brandtr@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[brandtr, 2017-05-02 09:03:44]

lgtm + 2 comments

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
(right):

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc:496:
layers_->UpdateLayerConfig(kStartTimestamp)));
clang-format?

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.h (right):

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:65: static int
EncodeFlags(TemporalReferences references);
Change return type to vpx_enc_frame_flags_t?

[pbos-webrtc, 2017-05-02 09:23:04]

Description was changed from

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

BUG=chromium:702017,webrtc:7349
R=stefan@webrtc.org,sprang@webrtc.org
==========

to

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

BUG=chromium:702017,webrtc:7349
R=brandt@webrtc.org
==========

[pbos-webrtc, 2017-05-02 09:23:04]

pbos@webrtc.org changed reviewers:
- sprang@webrtc.org, stefan@webrtc.org

[pbos-webrtc, 2017-05-02 09:23:10]

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
(right):

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc:496:
layers_->UpdateLayerConfig(kStartTimestamp)));
On 2017/05/02 09:03:44, brandtr wrote:
> clang-format?

Yep, actually clean (indentation inside EncodeFlags() call), because
VP8EncoderImpl::EncodeFlags... doesn't fit on a single line either way this
split is preferred.

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.h (right):

https://codereview.webrtc.org/2849723002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:65: static int
EncodeFlags(TemporalReferences references);
On 2017/05/02 09:03:44, brandtr wrote:
> Change return type to vpx_enc_frame_flags_t?

Done.

[pbos-webrtc, 2017-05-02 09:23:23]

rebase

[pbos-webrtc, 2017-05-02 09:24:24]

The CQ bit was checked by pbos@webrtc.org

[pbos-webrtc, 2017-05-02 09:24:24]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2849723002/#ps20001 (title:
"rebase   return type")

[commit-bot: I haz the power, 2017-05-02 09:24:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 09:51:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493717064117210,
"parent_rev": "fc31a43e3652df4c8e03bfff89858c4858d79b89", "commit_rev":
"fa18e25461c258dca30bd3c382863411f8c3b77b"}

[commit-bot: I haz the power, 2017-05-02 09:51:16]

Description was changed from

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

BUG=chromium:702017,webrtc:7349
R=brandt@webrtc.org
==========

to

==========
Extract TL config to VP8 libvpx flag conversion.

libvpx flags aren't applicable to hardware encoders or non-libvpx
software encoders. This moves libvpx flag conversion into the
VP8EncoderImpl integration.

BUG=chromium:702017,webrtc:7349
R=brandt@webrtc.org

Review-Url: https://codereview.webrtc.org/2849723002
Cr-Commit-Position: refs/heads/master@{#17970}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fa18e25461c258dca30bd3c38...
==========

[commit-bot: I haz the power, 2017-05-02 09:51:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/fa18e25461c258dca30bd3c38...