Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2848563002: Run some peer connection end-to-end tests with an empty audio decoder factory (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Run some peer connection end-to-end tests with an empty audio decoder factory Specifically, the tests that only use data channels shouldn't need any audio codec support; by using an audio decoder factory that supports no codecs, we ensure that this is the case. For completeness, I tried doing the same to the two tests that actually use audio and video; as expected, they fail, with messages like this: [000:032] (webrtcsession.cc:334): Failed to set remote sdp: Session error code: ERROR_CONTENT. Session error description: Failed to set local audio description recv parameters.. BUG=webrtc:5805 Review-Url: https://codereview.webrtc.org/2848563002 Cr-Commit-Position: refs/heads/master@{#17907} Committed: https://chromium.googlesource.com/external/webrtc/+/7a12b5ad8eafec0b85e7e474e094d34141d14a56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/pc/peerconnectionendtoend_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kwiberg-webrtc
3 years, 7 months ago (2017-04-27 10:15:15 UTC) #6
ossu
lgtm. I'll follow up with one for the encoder side once I've pushed the rest ...
3 years, 7 months ago (2017-04-27 10:37:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2848563002/1
3 years, 7 months ago (2017-04-27 10:53:26 UTC) #9
kwiberg-webrtc
On 2017/04/27 10:37:18, ossu wrote: > lgtm. I'll follow up with one for the encoder ...
3 years, 7 months ago (2017-04-27 10:55:05 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 10:56:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7a12b5ad8eafec0b85e7e474e...

Powered by Google App Engine
This is Rietveld 408576698