Issue 2846853002: audioproc_f with fake microphone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2846853002: audioproc_f with fake microphone. (Closed)

Created:
3 years, 8 months ago by aleloi

Modified:
3 years, 4 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

audioproc_f with fake microphone. [DO NOT SUBMIT] This is a test submission building on https://codereview.webrtc.org/2834643002/ by alebzk. It will be divided into smaller CLs. TODOs: * I don't like what currently goes on in ProcessStream. * Can the different cases (Wav/simulation) be handled more simply? * what about fixed interface? BUG=None yet

Patch Set 1 : Rebase. #

Patch Set 2 : Initialized FakeRecordingDevice, added 'kind' command line flag, fixed bugs. #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -27 lines)			Patch
M	webrtc/modules/audio_processing/BUILD.gn	View		4 chunks	+14 lines, -0 lines	0 comments	Download
M	webrtc/modules/audio_processing/test/aec_dump_based_simulator.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc	View	1	2 chunks	+18 lines, -18 lines	0 comments	Download
M	webrtc/modules/audio_processing/test/audio_processing_simulator.h	View	1	3 chunks	+4 lines, -1 line	0 comments	Download
M	webrtc/modules/audio_processing/test/audio_processing_simulator.cc	View	1	2 chunks	+20 lines, -4 lines	0 comments	Download
M	webrtc/modules/audio_processing/test/audioproc_float.cc	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
A	webrtc/modules/audio_processing/test/fake_recording_device.h	View		1 chunk	+79 lines, -0 lines	0 comments	Download
A	webrtc/modules/audio_processing/test/fake_recording_device.cc	View	1	1 chunk	+91 lines, -0 lines	0 comments	Download
A	webrtc/modules/audio_processing/test/fake_recording_device_unittest.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2834643002 Patch 40001

Messages

Total messages: 3 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #1 (id:40001) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages